Remove lodash.isobjectlike package #377
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chris-pardy
added a commit
to chris-pardy/json-rules-engine
that referenced
this pull request
Oct 11, 2024
Remove the lodash.isObjectLike library and inline the function Replaces CacheControl#377 Co-Author trkic-zeiss
The lodash package is being brought in via a transitive depenendcy, remove it entirely and in-line the method
Lodash is a transitive dependency, instead of relying on it just in-line the simple isObjectLike code
chris-pardy
approved these changes
Oct 11, 2024
CacheControl
approved these changes
Oct 12, 2024
chris-pardy
reviewed
Oct 14, 2024
…mant and reliable
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The presence of the dependency "lodash.isobjectlike": "^4.0.0" in the code is causing BlackDuck to report a vulnerability issue related to Prototype Pollution.
However, it seems unnecessary to load this dependency separately because the function isObjectLike is already available in the "lodash" library.
Furthermore, the issue related to Prototype Pollution has been addressed and fixed in version 4.17.12 of "lodash".
You can refer to the following link for additional information: https://security.snyk.io/vuln/SNYK-JS-LODASH-608086