Improve logger and debug #8
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I checked it, and it was great, but I had a misunderstanding about why sometimes state.world_model.stopped_cycle was 0 and other times it was 55. It would be great if you could explain this to me. |
SK2iP
reviewed
Oct 1, 2024
| directory = os.path.dirname(log_file) | ||
| if directory and not os.path.exists(directory): | ||
| os.makedirs(directory) | ||
|
|
There was a problem hiding this comment.
I think it would be better to add a variable that allows users to decide whether the previous log file should be saved or removed. I mean something like this :
if os.path.exists(log_dir):
timestamp = datetime.now().strftime("%Y-%m-%d_%H-%M-%S")
new_log_dir = f"debug/player_logs_{timestamp}"
shutil.move(log_dir, new_log_dir)
| @@ -10,6 +17,7 @@ fi | |||
|
|
|||
| team_name="CLS" | |||
| rpc_port=50051 | |||
| debug=false | |||
|
|
|||
| # help function | |||
| usage() { | |||
There was a problem hiding this comment.
Please add -d command to usage function so can people find the -d command
start-team.sh
Outdated
| @@ -1,5 +1,12 @@ | |||
| #!/bin/bash | |||
|
|
|||
| # remove logs directory | |||
| rm -rf logs | |||
There was a problem hiding this comment.
base on what i said in the logger_utils i think you should change here if we want to add that feature
|
@SK2iP Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.