Skip to content

TypeScript: Chapters 1-2 naming aligned with language standard #61

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 1, 2025
Merged

TypeScript: Chapters 1-2 naming aligned with language standard #61

merged 1 commit into from
Feb 1, 2025

Conversation

aikhelis
Copy link
Contributor

@aikhelis aikhelis commented Feb 1, 2025 •
edited
Loading

  • renamed functions, variables and constants from snake_case to camelCase to follow JS standard
  • ensured semicolons for consistency and to mitigate potential side effects
  • added TypeScript type definitions within functions, whre it improves code self-descriptiveness (custom arrays of pairs, triplets, sets and maps)

@aikhelis
Copy link
Contributor Author

aikhelis commented Feb 1, 2025

@Destiny-02 aligned existing TS solutions with language standards (previously was following Python as closely as possible), per your comment on Discord. It'd be good to get this validated and merged/rejected before further contributions in TS.

Destiny-02
Destiny-02 approved these changes Feb 1, 2025
View reviewed changes
Copy link
Collaborator

@Destiny-02 Destiny-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating this!

@Destiny-02 Destiny-02 merged commit 4d249f1 into ByteByteGoHq:main Feb 1, 2025
@aikhelis aikhelis deleted the typescript_solutions_naming_convention_refactor branch February 1, 2025 23:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Destiny-02 Destiny-02 Destiny-02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@aikhelis @Destiny-02