Skip to content

TypeScript: Chapter 3 Linked Lists #59

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 28 commits into from
Feb 5, 2025
Merged

TypeScript: Chapter 3 Linked Lists #59

merged 28 commits into from
Feb 5, 2025

Conversation

aikhelis
Copy link
Contributor

@aikhelis aikhelis commented Jan 31, 2025 •
edited
Loading

  • linked_list_reversal
  • linked_list_reversal_recursive
  • remove_kth_last_node
  • linked_list_intersection
  • lru_cache
  • palindromic_linked_list
  • flatten_multi_level_list

@aikhelis aikhelis changed the title Typescript: Chapter 3 Linked Lists TypeScript: Chapter 3 Linked Lists Feb 1, 2025
aikhelis and others added 25 commits February 1, 2025 15:00
@aikhelis
ts-3: camelCase naming
8a59277
@aikhelis
ts-3: remove kth last node
0bbb177
@aikhelis
ts-3: commend node definition
22ca124
@aikhelis
ts-3: intersection
2401f25
@aikhelis
ts-3: palindromic
e08e1a1
@Jer3myYu @aikhelis
add: InvertBinaryTreeRecursive and InvertBinaryTreeIterative
ac5cdd7
@Jer3myYu @aikhelis
add: BalancedBinaryTreeValidation
87309e4
@Jer3myYu @aikhelis
add: RightmostNodesOfABinaryTree
cbf04e1
@Jer3myYu @aikhelis
add: WidestBinaryTreeLevel
20c0102
@Jer3myYu @aikhelis
add: BinarySearchTreeValidation, use null to replace float('-inf') an…
92d90ef 
…d float('inf') in python solution
@Jer3myYu @aikhelis
add: LowestCommonAncestor
13e7aef
@Jer3myYu @aikhelis
add: BuildBinaryTree
54a8a98
@Jer3myYu @aikhelis
add: MaximumPathSum
c92cbf9
@Jer3myYu @aikhelis
add: BinaryTreeSymmetry
8ae766c
@Jer3myYu @aikhelis
add: BinaryTreeColumns
e2a2499
@Jer3myYu @aikhelis
add: KthSmallestNumberInBSTRecursive
a289665
@Jer3myYu @aikhelis
add: KthSmallestNumberInBSTIterative
0c05a1e
@Jer3myYu @aikhelis
add: SerializeAndDeserializeABinaryTree
5ba42ca
@aikhelis
ts-1 ts-2: naming aligned with language standard
dc941b6
@aikhelis
ts-3: flatten list
539d2ed
@aikhelis
ts-3: align remove-kth-last-node with canonical solution with assumed…
e6a13e9 
… constraints on input
@aikhelis
ts-3: added non-null assertions to inform typescript checks
b6281d8
@aikhelis
ts-3: lru cavhe
315a5f2
@aikhelis
ts-1: address typescript warning
a0b2254
@aikhelis
Merge branch 'main' into typescript_solutions_linked_lists
e7072d0
@aikhelis aikhelis marked this pull request as ready for review February 2, 2025 12:49
@aikhelis
Copy link
Contributor Author

aikhelis commented Feb 2, 2025

@Destiny-02 typescript chapter 3 is ready for review

Destiny-02
Destiny-02 requested changes Feb 3, 2025
View reviewed changes
Copy link
Collaborator

@Destiny-02 Destiny-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for all the progress on the TypeScript problems! Please see comments for changes requested.

@aikhelis
Copy link
Contributor Author

aikhelis commented Feb 3, 2025 •
edited
Loading

@Destiny-02 oh good spots, thanks! Done - mind glancing over it?

I defined ./ds.ts library file locally in the chapter folder and git-ignored it. I import data structures from it alongside a commented section with the imported DS definition. Is it how it's currently done in other languages?

@aikhelis aikhelis requested a review from Destiny-02 February 3, 2025 21:28
Destiny-02
Destiny-02 requested changes Feb 4, 2025
View reviewed changes
Copy link
Collaborator

@Destiny-02 Destiny-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for updating! Just 1 more requested change 🙏

@aikhelis aikhelis requested a review from Destiny-02 February 4, 2025 11:49
Destiny-02
Destiny-02 approved these changes Feb 5, 2025
View reviewed changes
Copy link
Collaborator

@Destiny-02 Destiny-02 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@Destiny-02 Destiny-02 merged commit eb4734f into ByteByteGoHq:main Feb 5, 2025
@aikhelis aikhelis deleted the typescript_solutions_linked_lists branch February 5, 2025 09:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Destiny-02 Destiny-02 Destiny-02 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aikhelis @Destiny-02 @Jer3myYu