Addition of a user-selectable dark-mode option #2022
Conversation
- Most elements done, but still need to do editors, tables and final pass. - Toggled only by quick js check at the moment, checking via css media query. Need to make into user-preference toggle. For #1234
ssddanbrown
changed the title
|
|
- Updated editor, and other area, styles to look okay in dark mode. - Used tinyMCE theme generator to create dark mode theme. - Updated tinymce to latest 4x version.
Generally seems to cause issues when secure images are in use. Was added during laravel upgrade but laravel does not use this directly for its web middleware anyway.
- Also fixed some remaining areas which needed dark mode support.
|
@ssddanbrown, is there a way to let guest users select dark mode? |
|
@over-soul Should be an option on the home screen. See above the right-most "Recent Activity" card here: |
|
Would it be possible to also place this button to switch between dark/light mode on the books, shelf, chapters page sites, e.g. as another item in the "Actions" section below "Export"? This would make is possible to change theme on book/page sites also an not only on the main home screen. |
|
@whentotrade Dark mode does not really relate to the items that the existing actions are centered around so I'd prefer not to add it there. Non guest users can toggle dark mode from any page via the top-right profile menu. |
|
Ok, thanks. Then maybe just on the /books page. As there the "dark/light mode" open is missing when you click on the "Books" tab from the tab. While when you choose "books" as the standard homepage, the switch button is there in the overview. This is the "Actions area" when setting "books" as the standard homepage in the settings (with switch button): Where as this is the "Action area" when clicking the main "Books" tab on the top bar (without switch option) Then main contant is the same - just the landing page selected as "books" in the settings shows the switch button while when clicking the "books" main tab the option is not visible. Just a proposal and observation. Thanks for the great work! |
For #1234