Added new endpoint, fix and added tests. #41

SanaviaNicolas · 2020-06-29T13:38:03Z

WORKSPACES

Added new endpoint with its methods(See official bitbucket API documentation):
- list();
- all();
- show();
Added tests
Added Workspaces/Repositories with its method: show()

PROJECTS

Added all() method
Fix create() and update() methods
Fix buildProjectPath() method, use workspaces

REPOSITORIES

Added workspaces() method
Added Repositories/Workspaces class with its methods:
- createRepository();
- showRepository();
- buildRepositoriesPath();
Added all() method on Team/Repositories

TESTS

Added mockup API features in order to test all endpoints

…cy/Client into added-project-and-workspace

GrahamCampbell · 2020-06-29T13:45:38Z

This PR seems to still be based off of 2.1 and not 3.0.

src/Api/Repositories/Workspaces.php

src/Api/Repositories/Workspaces/AbstractWorkspacesApi.php

src/Api/Teams/Projects.php

tests/responses/BaseResponse.php

…rkspace # Conflicts: # composer.json

Apply fixes from StyleCI

composer.json

Apply fixes from StyleCI

src/Api/Teams/Projects.php

src/Api/Teams/Repositories.php

src/Api/Workspaces.php

GrahamCampbell · 2020-06-29T19:42:35Z

I've added some examples to the README now, including how to use the paginator, which is why those all methods aren't needed: https://github.com/BitbucketAPI/Client/tree/6b8785635eeae87de7edd682968a0e305e5ab406#example-3.

Giacomo92 · 2020-06-29T19:57:14Z

@GrahamCampbell thank you for all the feedbacks. We will fix them soon. What do you think about test system? Can we add more test (like we have already did in this PR)?

GrahamCampbell · 2020-06-29T20:15:59Z

The tests are great. In fact, I might take over the src changes, since there are quite a lot of other changes not covered by this PR that I'd like to make. After I'm finished, if you rebase this PR, we should be just left with the tests.

GrahamCampbell · 2020-06-29T20:54:06Z

Ok, I've finished rigorously replacing teams/users stuff with workspaces: 2.1...3.0. I've also removed any deprecated endpoints. I just have left to go through the repositories endpoints to see if there's anything new they've added we don't yet support.

If you could rebase this PR, just providing the tests, that would be great. I'll then given them a review and we hopefully can merge this PR. :)

…rkspace # Conflicts: # src/Api/Repositories.php # src/Api/Repositories/Workspaces.php # src/Api/Repositories/Workspaces/AbstractWorkspacesApi.php # src/Api/Teams/Repositories.php # src/Api/Workspaces.php

Apply fixes from StyleCI

GrahamCampbell · 2020-06-30T10:21:22Z

Thanks for the PR. I'll finish off here, and merge locally. :)

GrahamCampbell · 2020-06-30T10:07:04Z

src/Api/Repositories/Workspaces/Repositories.php

+ *
+ * @author Graham Campbell <graham@alt-three.com>
+ */
+class Repositories extends AbstractWorkspacesApi


Please delete this. There is no such API.

GrahamCampbell · 2020-06-30T10:07:58Z

src/Api/Workspaces.php

+     *
+     * @return array
+     */
+    public function list(array $params = [])


Please delete this. This is already implemented on the "CurrentUser" API.

GrahamCampbell · 2020-06-30T10:09:26Z

src/Api/Workspaces/Projects.php

@@ -71,7 +71,7 @@ public function show(string $project, array $params = [])
     *
     * @return array
     */
-    public function update(string $project, array $params = [])


Please don't change this. We have params like this out of convention. If we want to review that, we'd want to do it for all cases, not just one, and not in this PR.

GrahamCampbell · 2020-06-30T10:10:45Z

src/Api/Workspaces/Projects.php

@@ -104,6 +104,6 @@ public function remove(string $project, array $params = [])
     */
    protected function buildProjectsPath(string ...$parts)
    {
-        return static::buildPath('workspaces', $this->username, 'projects', ...$parts);


This typo, and a few others are already fixed on 3.0.

GrahamCampbell · 2020-06-30T10:24:55Z

tests/responses/ProjectsAllResponse.php

+use Http\Message\ResponseFactory;
+use Psr\Http\Message\ResponseInterface;
+
+class ProjectsAllResponse extends BaseResponse implements ResponseFactory


Wrong to implement this interface, when you then disregard the parameters.

Replaces #41. Co-Authored-By: Giacomo Fabbian <info@giacomofabbian.it> Co-Authored-By: SanaviaNicolas <sanavianicolas@users.noreply.github.com>

Giacomo92 · 2020-06-30T11:30:50Z

Hi @GrahamCampbell , I have just seen the new PR. Good job!
Do you need an hand in to increase code coverage?

GrahamCampbell · 2020-06-30T11:59:58Z

I don't think getting 100% code coverage with that style of test is really going to add much value. It was certainly good to have a small number of those tests though, like you added, so thanks for that.

Those sorts of tests don't catch mistakes URLs generated by the code, which is the most common error, I think.

Giacomo92 · 2020-06-30T12:41:26Z

Can you give me an example of "mistakes URLs generated by the code"?

GrahamCampbell · 2020-06-30T13:23:17Z

#15

GrahamCampbell · 2020-06-30T13:53:00Z

The only way to catch those sorts of errors, is to actually hit the API, like in https://github.com/BitbucketAPI/Client/blob/46bf30101114dae032ed381642e91c2ba1e1a51a/tests/ClientTest.php#L35-L47. But, obviously our tests are going to be quite slow if we do this for all the endpoints. Anyway, I don't think we should. I think we have enough coverage from people using the code and letting us know.

One place where I think we could have better test coverage is the http plugins, however.

SanaviaNicolas and others added 13 commits June 26, 2020 18:45

[NS] First Commit

8003181

[GF] Setup tests

88f0461

[NS] update tests

94e6840

[GF] Removed unused dependency + add test script for composer

7d06940

[GF] Fix ci

be8ce6b

[GF] Removed unused dependencies

fc710b2

[NS] fix tests

938480b

Merge branch 'added-project-and-workspace' of github.com:offline-agen…

426bb9c

…cy/Client into added-project-and-workspace

[GF] Fix test and removed composer script

685fec8

[GF] Fix test

daf93c1

[NS] remove docs

499a83b

[NS] fix and update tests

09538e6

Merge branch 'added-project-and-workspace' of github.com:offline-agen…

b5243de

…cy/Client into added-project-and-workspace

GrahamCampbell requested changes Jun 29, 2020

View reviewed changes

SanaviaNicolas and others added 7 commits June 29, 2020 15:49

Merge remote-tracking branch 'upstream/3.0' into added-project-and-wo…

c35a591

…rkspace # Conflicts: # composer.json

[NS] revert last change

bc0a1e0

[NS] use interface

3b0079e

[NS] revert last change

d166b8d

[NS] fix update on teams/projects + fix projects tests

fce732a

Apply fixes from StyleCI

f985d66

Merge pull request #1 from offline-agency/analysis-J2EDvQ

93a295e

Apply fixes from StyleCI

GrahamCampbell requested changes Jun 29, 2020

View reviewed changes

composer.json Outdated Show resolved Hide resolved

composer.json Outdated Show resolved Hide resolved

GrahamCampbell marked this pull request as draft June 29, 2020 16:49

Giacomo Fabbian added 3 commits June 29, 2020 19:02

[GF] Fix requested changes

a65d013

Apply fixes from StyleCI

8dae0a0

Merge pull request #2 from offline-agency/analysis-EAB5pZ

45f309b

Apply fixes from StyleCI

GrahamCampbell requested changes Jun 29, 2020

View reviewed changes

Giacomo Fabbian added 5 commits June 30, 2020 00:24

[GF] Fix import + moved dependencies to require-dev

ab45989

Merge remote-tracking branch 'upstream/3.0' into added-project-and-wo…

b040d79

…rkspace # Conflicts: # src/Api/Repositories.php # src/Api/Repositories/Workspaces.php # src/Api/Repositories/Workspaces/AbstractWorkspacesApi.php # src/Api/Teams/Repositories.php # src/Api/Workspaces.php

[GF] Update tests

2e91bd5

Apply fixes from StyleCI

7898d70

Merge pull request #3 from offline-agency/analysis-D2K7vn

693245a

Apply fixes from StyleCI

GrahamCampbell closed this Jun 30, 2020

GrahamCampbell reviewed Jun 30, 2020

View reviewed changes

GrahamCampbell added a commit that referenced this pull request Jun 30, 2020

Added additional tests

1e171fe

Replaces #41. Co-Authored-By: Giacomo Fabbian <info@giacomofabbian.it> Co-Authored-By: SanaviaNicolas <sanavianicolas@users.noreply.github.com>

GrahamCampbell mentioned this pull request Jun 30, 2020

Added additional tests #50

Merged

Uh oh!

Added new endpoint, fix and added tests. #41

Added new endpoint, fix and added tests. #41

Uh oh!

Conversation

SanaviaNicolas commented Jun 29, 2020

WORKSPACES

PROJECTS

REPOSITORIES

TESTS

Uh oh!

GrahamCampbell commented Jun 29, 2020

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

GrahamCampbell commented Jun 29, 2020

Uh oh!

Giacomo92 commented Jun 29, 2020

Uh oh!

GrahamCampbell commented Jun 29, 2020

Uh oh!

GrahamCampbell commented Jun 29, 2020

Uh oh!

GrahamCampbell commented Jun 30, 2020

Uh oh!

GrahamCampbell Jun 30, 2020

Choose a reason for hiding this comment

Uh oh!

GrahamCampbell Jun 30, 2020

Choose a reason for hiding this comment

Uh oh!

GrahamCampbell Jun 30, 2020

Choose a reason for hiding this comment

Uh oh!

GrahamCampbell Jun 30, 2020

Choose a reason for hiding this comment

Uh oh!

GrahamCampbell Jun 30, 2020

Choose a reason for hiding this comment

Uh oh!

Giacomo92 commented Jun 30, 2020

Uh oh!

GrahamCampbell commented Jun 30, 2020

Uh oh!

Giacomo92 commented Jun 30, 2020

Uh oh!

GrahamCampbell commented Jun 30, 2020

Uh oh!

GrahamCampbell commented Jun 30, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

Uh oh!

GrahamCampbell commented Jun 30, 2020 •

edited

Loading