Update cppCode.ts

[kaigoh]

I know it's pedantic change on my behalf :)

Summary by CodeRabbit

• Bug Fixes
  • Adjusted HTTP caching header formatting to ensure consistent behavior and adherence to industry standards, which may enhance performance and content freshness for end-users.

[coderabbitai]

Walkthrough

The pull request updates the HTTP response header casing for cache control in the src/cppCode.ts file. Specifically, instances of "cache-control" have been changed to "Cache-Control" within methods of the PsychicHttpServer, PsychicHttpsServer, and AsyncWebServer classes. The underlying logic remains unchanged, and there are no modifications to exported or public entities.

Changes

File	Change Summary
src/cppCode.ts	Updated the cache control HTTP header casing from "cache-control" to "Cache-Control" across the code handling responses for PsychicHttpServer, PsychicHttpsServer, and AsyncWebServer.

Possibly related PRs

• feat: etag with cache-control #26: Addresses similar header casing changes in the handling of HTTP responses.
• Implement cache max age #37: Modifies caching behavior by introducing a new cachetime parameter in the same file, directly relating to the header changes.

---

📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between f8b1f60 and ebe7ad8.

📒 Files selected for processing (1)

• src/cppCode.ts (3 hunks)

🔇 Additional comments (6)

src/cppCode.ts (6)

171-178: Ensure Correct Header Casing in PsychicHttpServer (true case)
The updated code now uses "Cache-Control" (with capital “C”) instead of "cache-control", which aligns with standard HTTP header conventions. This change, applied when a valid cache time is provided, is pedantic but improves consistency.

---

179-189: Consistent Header Casing in PsychicHttpServer (compiler case)
Here, within the compiler-controlled block (wrapped by the #ifdef), the header is updated to "Cache-Control" in both the max-age and no-cache scenarios. The change is clear and consistent with the previous block.

---

356-365: Update Header Casing in PsychicHttpServerV2 (true case)
In the psychic2Template HTTP handler, the code now correctly uses "Cache-Control" in the branch when a cache time is provided, ensuring consistency in header casing. The change is minimal yet aligns with the overall pedantic adjustment.

---

366-376: Maintain Consistency in the Compiler Block for PsychicHttpServerV2
The "Cache-Control" header casing has been changed here as well, in both the cache time set and default scenarios, inside the compiler block controlled via preprocessor directives. This keeps the formatting uniform with the rest of the code.

---

547-556: Correct Header Casing in ESPAsyncWebServer Template (true case)
Within the asyncTemplate, the response header now uses "Cache-Control" (capital “C”) when a valid cache time is provided. This minor adjustment improves the clarity and conformance to HTTP standards.

---

557-568: Consistent Header Casing in ESPAsyncWebServer Compiler Block
Similar to the other templates, the compiler branch for the asyncTemplate now properly sets "Cache-Control" in both the max-age and no-cache conditions. This uniformity across templates is beneficial.

✨ Finishing Touches

• 📝 Generate Docstrings

---

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

• X
• Mastodon
• Reddit
• LinkedIn

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

• Review comments: Directly reply to a review comment made by CodeRabbit. Example:
  • I pushed a fix in commit <commit_id>, please review it.
  • Generate unit testing code for this file.
  • Open a follow-up GitHub issue for this discussion.
• Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
  • @coderabbitai generate unit testing code for this file.
  • @coderabbitai modularize this function.
• PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
  • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
  • @coderabbitai read src/utils.ts and generate unit testing code.
  • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
  • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

• @coderabbitai pause to pause the reviews on a PR.
• @coderabbitai resume to resume the paused reviews.
• @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
• @coderabbitai full review to do a full review from scratch and review all the files again.
• @coderabbitai summary to regenerate the summary of the PR.
• @coderabbitai generate docstrings to generate docstrings for this PR.
• @coderabbitai resolve resolve all the CodeRabbit review comments.
• @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
• @coderabbitai help to get help.

Other keywords and placeholders

• Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
• Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
• Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

• You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
• Please see the configuration documentation for more information.
• If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

• Visit our Documentation for detailed information on how to use CodeRabbit.
• Join our Discord Community to get help, request features, and share feedback.
• Follow us on X/Twitter for updates and announcements.

[BCsabaEngine]

Header fields are case-insensitive, but I like pretty solution and Cache-Control should similar to ETag. thx!

[BCsabaEngine]

https://github.com/BCsabaEngine/svelteesp32/releases/tag/v1.8.1

[kaigoh]

Welcome!