Make 'HttpResponseContext' not needed in PS function script #113
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Make
HttpResponseContext
not needed in PS function script.To properly convert a value for a specific output binding name implicitly, we need to know the metadata of the binding referred by that name, such as the type of the output binding.
The changes in this PR register the output binding metadata to a concurrent dictionary with the Runspace's InstanceId as the key before start running a function script, and then un-register after the function script finishes running. When a function script that calls
Push-OutputBinding
is running, we can figure out the current Runspace byRunspace.DefaultRunspace
, and then we can query for the output binding metadata by using the InstanceId.This approach take into the concurrency support that we will have in future.
Push-OutputBinding
is able to get the metadata about the function script that is running even with multiple Runspaces/PowerShellManagers processing requests at the same time.Fix #93