Skip to content

Permission update from Directory.Read.All to GroupMember.Read.All #388

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 23 commits into from
Sep 24, 2020
Merged

Permission update from Directory.Read.All to GroupMember.Read.All #388

merged 23 commits into from
Sep 24, 2020

Conversation

Shama-K
Copy link
Contributor

@Shama-K Shama-K commented Aug 5, 2020 •
edited
Loading

Purpose

Updated code and Readme files to include GroupMember.Read.All permission. Updated implementation to handle Groups overage scenario.

Note: Code snippet will be updated once code is approved.

Does this introduce a breaking change?

[ ] Yes
[x ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ x] Refactoring (no functional changes, no api changes)
[ x] Documentation content changes
[ ] Other... Please describe:

How to Test

Use manual steps or app creation scripts to configure the sample, and run the sample.
Test the code.

@Shama-K Shama-K marked this pull request as ready for review August 5, 2020 19:48
derisen
derisen reviewed Aug 5, 2020
View reviewed changes
derisen
derisen reviewed Aug 5, 2020
View reviewed changes
derisen
derisen approved these changes Aug 5, 2020
View reviewed changes
Copy link
Contributor

@derisen derisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

one comment, otherwise LGTM!

jmprieur
jmprieur approved these changes Aug 6, 2020
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @Shama-K

derisen
derisen approved these changes Sep 21, 2020
View reviewed changes
Copy link
Contributor

@derisen derisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Setup, registrations and running steps are clear. App works without issue. LGTM -thanks Shama

kalyankrishna1
kalyankrishna1 reviewed Sep 22, 2020
View reviewed changes
kalyankrishna1
kalyankrishna1 reviewed Sep 22, 2020
View reviewed changes
kalyankrishna1
kalyankrishna1 reviewed Sep 22, 2020
View reviewed changes
kalyankrishna1
kalyankrishna1 reviewed Sep 22, 2020
View reviewed changes
TiagoBrenck
TiagoBrenck approved these changes Sep 22, 2020
View reviewed changes
Copy link
Contributor

@TiagoBrenck TiagoBrenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@lgtm, thanks Shama

kalyankrishna1
kalyankrishna1 reviewed Sep 24, 2020
View reviewed changes
kalyankrishna1
kalyankrishna1 approved these changes Sep 24, 2020
View reviewed changes
Copy link
Contributor

@kalyankrishna1 kalyankrishna1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@Shama-K Shama-K merged commit 1bc7227 into master Sep 24, 2020
@jmprieur jmprieur deleted the Shama-K/GroupMemberPermission branch October 12, 2020 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalyankrishna1 kalyankrishna1 kalyankrishna1 approved these changes

@derisen derisen derisen approved these changes

@TiagoBrenck TiagoBrenck TiagoBrenck approved these changes

@idg-sam idg-sam Awaiting requested review from idg-sam

@jmprieur jmprieur Awaiting requested review from jmprieur

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@Shama-K @kalyankrishna1 @derisen @jmprieur @TiagoBrenck