Skip to content

Updated the instructions to reflect the code #384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 26, 2020
Merged

Updated the instructions to reflect the code #384

merged 2 commits into from
Jul 26, 2020

Conversation

MisinformedDNA
Copy link
Contributor

@MisinformedDNA MisinformedDNA commented Jul 24, 2020 •
edited
Loading

Purpose

The README says to do something that was not compliable (probably due to API changes). This just chances a code block to reflect what is in the code.

Does this introduce a breaking change?

[ ] Yes
[X ] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ X] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

jmprieur
jmprieur approved these changes Jul 26, 2020
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @MisinformedDNA

@jmprieur jmprieur merged commit dc1cd5e into Azure-Samples:master Jul 26, 2020
@MisinformedDNA MisinformedDNA deleted the patch-1 branch August 18, 2020 21:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@MisinformedDNA @jmprieur