API updates for 0.2.0-preview #371
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jmprieur
approved these changes
Jul 9, 2020
2-WebApp-graph-user/2-2-TokenCache/README-incremental-instructions.md
Outdated
Show resolved
Hide resolved
…ions.md Co-authored-by: Jean-Marc Prieur <jmprieur@microsoft.com>
jennyf19
changed the title
pmaytak
approved these changes
Jul 9, 2020
| @@ -85,11 +86,9 @@ public void ConfigureServices(IServiceCollection services) | |||
| }; | |||
| }, options => | |||
There was a problem hiding this comment.
Remove cookie action after PR 309 is merged.
Comment on lines
-48
to
-52
| // This is required to be instantiated before the OpenIdConnectOptions starts getting configured. | ||
| // By default, the claims mapping will map claim names in the old format to accommodate older SAML applications. | ||
| // 'http://schemas.microsoft.com/ws/2008/06/identity/claims/role' instead of 'roles' | ||
| // This flag ensures that the ClaimsIdentity claims collection will be built from the claims in the token | ||
| // JwtSecurityTokenHandler.DefaultMapInboundClaims = false; |
There was a problem hiding this comment.
Hmm, wonder if we need to leave this comment?
There was a problem hiding this comment.
It depends on the version of Wilson. ?
|
@kalyankrishna1 @TiagoBrenck @Shama-K |
(as the appsettings.json and the Startup.cs were inconsistent)
otherwise by default this will be OpenIdConnect
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TODO:
cc: @jmprieur