Skip to content

Multi Tenant sample for Web App calling Web API #370

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 38 commits into from
Jul 24, 2020

Conversation

Shama-K
Copy link
Contributor

@Shama-K Shama-K commented Jun 21, 2020

Purpose

Added sample to demonstrate multi-tenancy in the scenario where Web App calls Web API.

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[x ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

How to Test

Use manual steps or app creation scripts to configure the sample, and run the sample.
Test the code.

Copy link
Contributor

@derisen derisen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good work Shama, LGTM! Few comments:

  1. If KnownClientApplication is required, there should be steps in "Registration"
  2. I suggest setting TenantID: common (or organizations) as default in appsettings.json files since the sample is multitenant.
  3. Double check to confirm if Implicit Flow: ID Token is needed in Web API Registration steps
  4. In Prerequisites, I suggest removing trivial items like "internet connection", "windows machine" etc.

@idg-sam
Copy link
Contributor

idg-sam commented Jul 13, 2020

Runs great from within Windows!

  1. Instructions for running from Linux or WSL
  2. There was some certificate errors when I tried to run from WSL

Copy link
Contributor

@TiagoBrenck TiagoBrenck left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @Shama-K

@kalyankrishna1 kalyankrishna1 merged commit 428081d into master Jul 24, 2020
@MisinformedDNA
Copy link
Contributor

Thanks! This repo is very helpful.

@jmprieur jmprieur deleted the shama/MultiTenant branch August 4, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants