Skip to content

update to 0.1.2-preview #344

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
May 7, 2020
Merged

update to 0.1.2-preview #344

merged 1 commit into from
May 7, 2020

Conversation

jennyf19
Copy link
Contributor

@jennyf19 jennyf19 commented May 6, 2020

@jmprieur needs testing

@jennyf19 jennyf19 requested a review from jmprieur May 6, 2020 03:28
pmaytak
pmaytak approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍
LGTM but will defer to you after testing.

jmprieur
jmprieur approved these changes May 6, 2020
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks @jennyf19

@jennyf19
Copy link
Contributor Author

jennyf19 commented May 6, 2020

@pmaytak lmk if you run into issues. thx for testing.

@jmprieur jmprieur merged commit ab336d5 into master May 7, 2020
@jennyf19 jennyf19 deleted the jennyf/update0.1.2 branch June 13, 2020 00:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

@pmaytak pmaytak pmaytak approved these changes

Assignees
No one assigned
Labels
merge after ms identity web release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jennyf19 @jmprieur @pmaytak