Skip to content

Microsoft.Identity.Web.UI optional steps #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Apr 22, 2020
Merged

Conversation

TiagoBrenck
Copy link
Contributor

Purpose

Added optional step on first samples, explaining how to setup Microsoft.Identity.Web.UI

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome @TiagoBrenck

BTW there are 2 web apps templates now: https://github.com/AzureAD/microsoft-identity-web/wiki/web-app-template, but this content is super useful.

@TiagoBrenck TiagoBrenck merged commit 0eaaf9f into master Apr 22, 2020
@TiagoBrenck TiagoBrenck deleted the tibre/webUiDocs branch April 24, 2020 20:06
Copy link
Contributor

@pmaytak pmaytak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

(Just some nit comments.)

@@ -172,13 +172,34 @@ cd "1-WebApp-OIDC\1-1-MyOrg"
- update the `sslPort` of the `iisSettings` section to be `44321`
- in the `applicationUrl` property of use `https://localhost:44321`

1. (Optional) If you don't have a custom `AccountController` to handle the *sign-in* and *sign-out* requests, you can use the `Microsoft.Identity.Web.UI` built-in one. For that, please include this change on **Startup.cs**:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: change on > change in?

```CSharp
using Microsoft.Identity.Web.UI;
```
- in the `ConfigureServices` method, change the **AddControllersWithView** code snippet with this:
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: with this > to this

}).AddMicrosoftIdentityUI();
```

- on **Views/Shared/_LoginPartial.cshtml**, change the **asp-area** tag to: `asp-area="MicrosoftIdentity"`
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: on > in

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants