Skip to content

Explanation about guest users on MT apps #306

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Feb 20, 2020
Merged

Explanation about guest users on MT apps #306

merged 3 commits into from
Feb 20, 2020

Conversation

TiagoBrenck
Copy link
Contributor

Purpose

Added an explanation about /common endpoint and guest users.

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[x] Documentation content changes
[ ] Other... Please describe:

jmprieur
jmprieur approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesome. Thanks @TiagoBrenck

pmaytak
pmaytak approved these changes Feb 20, 2020
View reviewed changes
jennyf19
jennyf19 reviewed Feb 20, 2020
View reviewed changes
jennyf19
jennyf19 reviewed Feb 20, 2020
View reviewed changes
jennyf19
jennyf19 reviewed Feb 20, 2020
View reviewed changes
jennyf19
jennyf19 reviewed Feb 20, 2020
View reviewed changes
jennyf19
jennyf19 approved these changes Feb 20, 2020
View reviewed changes
Copy link
Contributor

@jennyf19 jennyf19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:shipit:

@jennyf19
Copy link
Contributor

jennyf19 commented Feb 20, 2020 •
edited
Loading

@TiagoBrenck this is super! can we put this wording somewhere in the MSAL repo as well? it's very clear. well done.
Maybe somewhere in here?

In reply to: 362081420 [](ancestors = 362081420)

@TiagoBrenck TiagoBrenck merged commit 8bc219b into master Feb 20, 2020
@TiagoBrenck TiagoBrenck deleted the tibre/updateMT_Readme branch February 20, 2020 18:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kalyankrishna1 kalyankrishna1 kalyankrishna1 approved these changes

@jmprieur jmprieur jmprieur approved these changes

@jennyf19 jennyf19 jennyf19 approved these changes

@pmaytak pmaytak pmaytak approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@TiagoBrenck @jennyf19 @kalyankrishna1 @jmprieur @pmaytak