Skip to content

Removing unnecessary comments #219

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Dec 3, 2019
Merged

Removing unnecessary comments #219

merged 2 commits into from
Dec 3, 2019

Conversation

TiagoBrenck
Copy link
Contributor

Purpose

Removed unnecessary comment and unused param

Does this introduce a breaking change?

[ ] Yes
[x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[x] Refactoring (no functional changes, no api changes)
[ ] Documentation content changes
[ ] Other... Please describe:

@TiagoBrenck TiagoBrenck requested a review from jmprieur December 3, 2019 23:21
jmprieur
jmprieur approved these changes Dec 3, 2019
View reviewed changes
Copy link
Contributor

@jmprieur jmprieur left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Thanks @TiagoBrenck

@TiagoBrenck TiagoBrenck merged commit 6f3692c into master Dec 3, 2019
@TiagoBrenck TiagoBrenck deleted the tibre/refactor branch December 3, 2019 23:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jmprieur jmprieur jmprieur approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@TiagoBrenck @jmprieur