Skip to content

Addressing customer questions #203

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Nov 13, 2019
Merged

Addressing customer questions #203

merged 3 commits into from
Nov 13, 2019

Conversation

jmprieur
Copy link
Contributor

Purpose

Improved troubleshooting and next steps based on customer's questions

  • ...

Does this introduce a breaking change?

[ ] Yes
[ x] No

Pull Request Type

What kind of change does this Pull Request introduce?

[ ] Bugfix
[ ] Feature
[ ] Code style update (formatting, local variables)
[ ] Refactoring (no functional changes, no api changes)
[ x] Documentation content changes
[ ] Other... Please describe:

How to Test

  • Get the code
git clone [repo-address]
cd [repo-name]
git checkout [branch-name]
  • Test the code

What to Check

Verify that the following are valid

  • ...

Other Information

jennyf19
jennyf19 reviewed Nov 12, 2019
View reviewed changes
3-WebApp-multi-APIs/README.md Outdated
@@ -189,6 +189,8 @@ insert

## Troubleshooting

To access Azure Resource Management (ARM), you'll need a work or School account (AAD account) and an Azure subscription. If your azure subscription is for a Microsoft personal account, just create a new user in your directory, and use this user to run the sample
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: does "school" have to be uppercase?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@jmprieur i fixed it directly into your branch

@jmprieur jmprieur merged commit 5fc5e04 into master Nov 13, 2019
@jmprieur jmprieur deleted the customerQuestions branch November 25, 2019 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jennyf19 jennyf19 jennyf19 approved these changes

@TiagoBrenck TiagoBrenck TiagoBrenck approved these changes

@kalyankrishna1 kalyankrishna1 Awaiting requested review from kalyankrishna1

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jmprieur @TiagoBrenck @jennyf19