Skip to content

Use Cabal-syntax to parse cabal packages #48

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Oct 19, 2022
Merged

Use Cabal-syntax to parse cabal packages #48

merged 4 commits into from
Oct 19, 2022

Conversation

pepeiborra
Copy link
Contributor

@pepeiborra pepeiborra commented Sep 16, 2022 •
edited
Loading

There's actually two changes here:

  1. Parse using the cabal-syntax package. This fixes bugs for descriptors that put source dirs in common stanzas, like this one.
  2. Generate one hie-bios component per module, instead of one per hs-source-dir. This fixes issues in projects that reuse the same hs-source-dir in multiple Cabal components, like the one linked above does too.

@pepeiborra
Copy link
Contributor Author

@Avi-D-coder do I need to do anything to get this change into implicit-hie-cradle too ?

pepeiborra added a commit to facebookincubator/Glean that referenced this pull request Sep 16, 2022
@pepeiborra
Fix the HLS experience
2ac8e2a 
Without an explicit cradle, HLS will generate one dynamically and hit [two bugs](Avi-D-coder/implicit-hie#48) in the implicit-hie library.

With the explicit Cabal cradle, HLS will interrogate `cabal repl` to find components, which sidesteps the bugs in implicit-hie
@pepeiborra pepeiborra mentioned this pull request Sep 16, 2022
Closed
facebook-github-bot pushed a commit to facebookincubator/Glean that referenced this pull request Sep 19, 2022
@pepeiborra @facebook-github-bot
Fix the HLS experience (#281)
00ba67f 
Summary:
Without an explicit cradle, HLS will generate one dynamically and hit [two bugs](Avi-D-coder/implicit-hie#48) in the implicit-hie library.

With the explicit Cabal cradle, HLS will interrogate `cabal repl` to find components, which sidesteps the bugs in implicit-hie

Pull Request resolved: #281

Reviewed By: nhawkes

Differential Revision: D39573729

Pulled By: pepeiborra

fbshipit-source-id: 7f2a5fe8cee8c664cb1ef7e5ac1a7df05e26694b
@Avi-D-coder Avi-D-coder merged commit b2a7de6 into Avi-D-coder:master Oct 19, 2022
@Avi-D-coder
Copy link
Owner

@pepeiborra I published implicit-hie-0.1.3.0 with the changes in this pr. implicit-hie-cradle builds with implicit-hie-0.1.3.0 . So now just HLS and anything else upstream has to updated.

@Avi-D-coder Avi-D-coder mentioned this pull request Oct 19, 2022
Closed
@fendor fendor mentioned this pull request Oct 21, 2022
Open
@Avi-D-coder Avi-D-coder mentioned this pull request Nov 16, 2022
Open
@Avi-D-coder
Copy link
Owner

@pepeiborra Does a minimal hie.yaml with cradle: {cabal: {}} cause issues on your project?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pepeiborra @Avi-D-coder