Clean up portable memory definitions #973
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Related: #971
This PR cleans up the portable memory definitions by, well, removing them completely. These have been of very little use anyway because there isn't a good memory story in JS. The compiler now uses bindings to Binaryen's
_malloc
etc. directly, which is much clearer. There's more to consider once we want to compile the compiler to Wasm, but leaving that for later.