Skip to content

Added spelling CI #316

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Oct 28, 2021
Merged

Added spelling CI #316

merged 8 commits into from
Oct 28, 2021

Conversation

prestoncarman
Copy link
Contributor

Highlights from CHANGELOG.md

  • Added a CI workflow to check for spelling errors

Issues Fixed

@ianfixes
Copy link
Collaborator

I'm embarrassed to see how thoroughly overdue this was. Thank's for adding it.

However, everything under cpp/arduino/avr should be ignored -- these are copied from the Arduino project and it will make diffs really difficult if we make cosmetic changes in there.

The changes to those files should be reverted and the spellchecker should be configured to ignore that directory.

@prestoncarman
Copy link
Contributor Author

The files under cpp/arduino/avr have been reverted and the configuration for codespell has been update to ignore this directory.

@prestoncarman prestoncarman mentioned this pull request Oct 26, 2021
@ianfixes ianfixes self-requested a review October 28, 2021 13:28
Copy link
Collaborator

@ianfixes ianfixes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Awesum! This wsa soerly nedeed.

@jgfoster jgfoster merged commit cef0f02 into Arduino-CI:master Oct 28, 2021
@prestoncarman prestoncarman deleted the spelling branch November 1, 2021 19:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Spell Checker
3 participants