Skip to content

Support for dtostrf() #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 53 commits into from
Closed

Support for dtostrf() #309

wants to merge 53 commits into from

Conversation

jgfoster
Copy link
Member

@jgfoster jgfoster commented Sep 2, 2021

This is a function provided by Arduino that isn't in the standard C library.

jgfoster and others added 30 commits February 15, 2021 10:47
@jgfoster
Set all text files to have endings
0750d59
@jgfoster
Update workflow to test on push.
32a0218
@jgfoster
Add to CHANGELOG.md
aed9f38
@jgfoster
Update CHANGELOG.md to describe line endings change.
9a76e70
@jgfoster
Update to more descriptive line ending handling.
c88d7d7
@jgfoster
Use before(:each) rather than before(:all) as recommended [here](h…
4648fda 
…ttps://makandracards.com/makandra/11507-using-before-all-in-rspec-will-cause-you-lots-of-trouble-unless-you-know-what-you-are-doing) to fix Arduino-CI#288.
@jgfoster
Hide build artifacts.
90c5504
@jgfoster
Add note to CHANGELOG.md.
86c8e95
@jgfoster
Reeplace deprecated function call.
a516e7c
@jgfoster
Speed up tests by building a shared library with everything but the t…
4667db9 
…ests and reusing it for each test.
@jgfoster
Add meaningful comments and remove commented-out code.
2284f1d
@jgfoster
See if this fixes the lint complaints.
452cf08
@jgfoster
Build single test executable if we don't have a shared library.
24c37b6
@jgfoster
Use File.exist?() instead of File.exists?().
432828f
@jgfoster
Set LD_LIBRARY_PATH to directory with shared library.
009f732
@jgfoster
Fix formatting (lint) issue.
e24ec9e
@jgfoster
Should find LD_LIBRARY_PATH on Linux.
2f5153f
@ianfixes
Merge branch 'master' into line-endings
ea4b72f
@ianfixes
Update gitattributes as per PR discussion
aa2ad44 
via Arduino-CI#285
Stream::readStreamUntil() should not return delimiter.
e67d2e9
Update CHANGELOG.md
a12369b
@jgfoster
Merge branch 'test_on_push' of github.com:jgfoster/arduino_ci
1864596 
# Conflicts:
#	CHANGELOG.md
@jgfoster
Merge branch 'line-endings' of github.com:jgfoster/arduino_ci
c348146
@jgfoster
Merge branch 'report_compile_errors' of github.com:jgfoster/arduino_ci
1fd65a2
@jgfoster
Merge branch 'hide_build_artifacts' of github.com:jgfoster/arduino_ci
b9b45e4
@jgfoster
Merge branch 'shared_library' of github.com:jgfoster/arduino_ci
8228104
@jgfoster
Merge branch 'readStringUntil' of github.com:jgfoster/arduino_ci
b201781
@jgfoster
Fix test run problem from merge.
ba00749
@jgfoster
Fix problem with hiding build artifacts.
1cfccdf
@jgfoster
Replace #define yield() _NOP() with `inline void yield() { _NOP(); …
5f9db70 
…}` so that other code can define a `yield()` function.
jgfoster and others added 23 commits July 1, 2021 08:49
@jgfoster
CHANGELOG.md
e52667e
@jgfoster
Merge branch 'yield'
4f287f2
@jgfoster
Add _BV() macro.
6762e63
@jgfoster
Merge branch 'BV_macro'
c70ecf2
Add avr/wdt.h and simple test that ensures the header can be found …
7ad4a74 
…and the functions can be called.
Merge branch 'watch-dog-timer' into main
f7bb619
Rule of three: if you have a custom destructor, then you probably nee…
f8ab8b8 
…d a custom copy constructor and a custom copy assignment operator.
Merge branch 'Client_assignment_operator'
cec111c
Remove debugging output.
4be329e
Merge branch 'Client_assignment_operator'
6b17c08
@jgfoster
Fix memory leak in copy constructor and copy assignment operator.
a9ac410
@jgfoster
Merge branch 'Client_assignment_operator'
f7eec1a
@jgfoster
Further work to address copy assignment memory leak.
e323378
@jgfoster
Merge branch 'Client_assignment_operator'
175a82c
@jgfoster
* Report output from compile.
362cf15 
* Allow test for minimum free space.
@jgfoster
Add in missed code.
c23fbd0
@jgfoster
Merge branch 'free_memory'
361629b
@jgfoster
Do not use parenthesis for method calls with no arguments.
8d58657
@jgfoster
Merge branch 'free_memory'
ea9b1fa
@jgfoster
Another parenthesis with no arguments!
c299364
@jgfoster
Merge branch 'free_memory'
b3e0bd7
Fix problem with warnings (Arduino-CI#297).
9c61a44
Add support for dtostrf().
4a3f8de
@jgfoster
Copy link
Member Author

jgfoster commented Sep 2, 2021

Sorry, this should have been a branch from master. Let me know if you want it resubmitted.

@jgfoster
Copy link
Member Author

jgfoster commented Oct 4, 2021 •
edited
Loading

This PR was a branch from main instead of master so has been replaced with #313 (was, incorrectly #309!).

@jgfoster jgfoster closed this Oct 4, 2021
@ianfixes
Copy link
Collaborator

ianfixes commented Oct 4, 2021 •
edited
Loading

edit: 309 is a typo, #313 is the replacement

@jgfoster
Copy link
Member Author

jgfoster commented Oct 4, 2021

Yes, that's right. My main has all my changes merged into it and I should be making my PRs on a branch from master which tracks upstream master. I made the mistake of branching from my main so the initial PR had a huge number of modified files. In order to do a clean merge I recreated the proposed changes in a clean PR.

@jgfoster
Copy link
Member Author

jgfoster commented Oct 4, 2021

And, if you have any substantive comments on closed PRs (like this one), I'm happy to revert or supplement...

@ianfixes
Copy link
Collaborator

ianfixes commented Oct 4, 2021

Any changes that have unit tests attached are generally fine with me, we can always add to the suite if/when we find a problem with the implementation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jgfoster @ianfixes