Skip to content

Revert "Renamed CursorResponse to PostCursorResponse" #433

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Original file line number Diff line number Diff line change
Expand Up @@ -319,7 +319,7 @@ public async Task PutCursorAsync_ShouldThrow_WhenCursorDoesNotExist()
[Fact]
public async Task PutCursorAsync_ShouldReturnResponseModelWithInterface()
{
PostCursorResponse<int> postResponse =
CursorResponse<int> postResponse =
await _cursorApi.PostCursorAsync<int>("FOR i IN 0..1500 RETURN i");

ICursorResponse<int> putResult =
Expand Down
6 changes: 3 additions & 3 deletions arangodb-net-standard/CursorApi/CursorApiClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,7 @@ protected virtual WebHeaderCollection GetHeaderCollection(CursorHeaderProperties
/// <param name="transactionId">Optional. The stream transaction Id.</param>
/// <param name="token">A CancellationToken to observe while waiting for the task to complete or to cancel the task.</param>
/// <returns></returns>
public virtual async Task<PostCursorResponse<T>> PostCursorAsync<T>(
public virtual async Task<CursorResponse<T>> PostCursorAsync<T>(
string query,
Dictionary<string, object> bindVars = null,
PostCursorOptions options = null,
Expand Down Expand Up @@ -116,7 +116,7 @@ public virtual async Task<PostCursorResponse<T>> PostCursorAsync<T>(
/// <param name="headerProperties">Optional. Additional Header properties.</param>
/// <param name="token">A CancellationToken to observe while waiting for the task to complete or to cancel the task.</param>
/// <returns></returns>
public virtual async Task<PostCursorResponse<T>> PostCursorAsync<T>(
public virtual async Task<CursorResponse<T>> PostCursorAsync<T>(
PostCursorBody postCursorBody,
CursorHeaderProperties headerProperties = null,
CancellationToken token = default)
Expand All @@ -131,7 +131,7 @@ public virtual async Task<PostCursorResponse<T>> PostCursorAsync<T>(
if (response.IsSuccessStatusCode)
{
var stream = await response.Content.ReadAsStreamAsync().ConfigureAwait(false);
return DeserializeJsonFromStream<PostCursorResponse<T>>(stream);
return DeserializeJsonFromStream<CursorResponse<T>>(stream);
}

throw await GetApiErrorException(response).ConfigureAwait(false);
Expand Down
4 changes: 2 additions & 2 deletions arangodb-net-standard/CursorApi/ICursorApiClient.cs
Original file line number Diff line number Diff line change
Expand Up @@ -25,7 +25,7 @@ public interface ICursorApiClient
/// <param name="transactionId">Optional. The stream transaction Id.</param>
/// <param name="token">A CancellationToken to observe while waiting for the task to complete or to cancel the task.</param>
/// <returns></returns>
Task<PostCursorResponse<T>> PostCursorAsync<T>(
Task<CursorResponse<T>> PostCursorAsync<T>(
string query,
Dictionary<string, object> bindVars = null,
PostCursorOptions options = null,
Expand All @@ -48,7 +48,7 @@ Task<PostCursorResponse<T>> PostCursorAsync<T>(
/// <param name="headerProperties">Optional. Additional Header properties.</param>
/// <param name="token">A CancellationToken to observe while waiting for the task to complete or to cancel the task.</param>
/// <returns></returns>
Task<PostCursorResponse<T>> PostCursorAsync<T>(
Task<CursorResponse<T>> PostCursorAsync<T>(
PostCursorBody postCursorBody,
CursorHeaderProperties headerProperties = null,
CancellationToken token = default);
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ namespace ArangoDBNetStandard.CursorApi.Models
/// Response from ArangoDB when creating a new cursor.
/// </summary>
/// <typeparam name="T"></typeparam>
public class PostCursorResponse<T> : ICursorResponse<T>
public class CursorResponse<T> : ICursorResponse<T>
{
/// <summary>
/// Indicates whether an error occurred
Expand Down Expand Up @@ -62,4 +62,4 @@ public class PostCursorResponse<T> : ICursorResponse<T>
/// </summary>
public string Id { get; set; }
}
}
}