Use IntersectionObserver when it's available #6
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
zephraph
reviewed
Dec 12, 2018
|
|
||
| class PlaceholderWithoutTracking extends React.Component { | ||
| constructor(props) { | ||
| super(props); | ||
|
|
||
| if (!window.LAZY_LOAD_OBSERVER) { |
There was a problem hiding this comment.
window may be undefined if you're in an SSR context.
There was a problem hiding this comment.
Good catch! I think I started this branch before react-lazy-load-image-component added support to SSR, that's why at that time using window to store the observer seemed ok.
I fixed this here: 364ce21.
Aljullu
force-pushed
the
intersection-observer
branch
2 times, most recently
from
ecb4132 to
bf50c3f
Compare
Aljullu
force-pushed
the
intersection-observer
branch
from
bf50c3f to
c73bdaa
Compare
Aljullu
force-pushed
the
intersection-observer
branch
from
4f8f2b1 to
8d1805c
Compare
Aljullu
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #16.