Skip to content

add PropTypes, defautProps to LazyLoadImage.jsx #3

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 31, 2018
Merged

add PropTypes, defautProps to LazyLoadImage.jsx #3

merged 7 commits into from
Aug 31, 2018

Conversation

partykyoung
Copy link

Hello @Aljullu
Thank you for your comments.

I added PropTypes and defaultProps in Alphabet order.
If I made a mistake, please tell me.

@Aljullu Aljullu self-requested a review July 28, 2018 08:15
@Aljullu
Copy link
Owner

Aljullu commented Jul 28, 2018

Thank you for your changes @partykyoung!

I'm not sure, however, how the last commit you added is related to the props changed in the first commit. If they are not related, it would be better to split the changes in different PR. How does it sound?

@partykyoung
Copy link
Author

@Aljullu
Ok! I will do this :)

  ● Test suite failed to run
    SecurityError: localStorage is not available for opaque origins
      
      at Window.get localStorage [as localStorage] (node_modules/jsdom/lib/jsdom/browser/Window.js:257:15)
      at Array.forEach (native)

I saw this error message, So I looked for a way to fix this error and found this link and added testUrl to package.json. I'm sorry I did not write a comment.

jsdom/jsdom#2304

- package.json
- LazyLoadImage.spec.js
@Aljullu Aljullu mentioned this pull request Aug 4, 2018
@Aljullu Aljullu merged commit f4c5a7c into Aljullu:master Aug 31, 2018
@Aljullu
Copy link
Owner

Aljullu commented Aug 31, 2018

Good work, just merged it to master! @partykyoung thanks for working on that!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants