Skip to content

Fix cortex-m33 armlink error #9625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Feb 7, 2019
Merged

Fix cortex-m33 armlink error #9625

merged 1 commit into from
Feb 7, 2019

Conversation

mikisch81
Copy link
Contributor

Description

When building Cortex-m33 on ARMC6 a linkage error happen due to the fact that armlink uses the --cpu=cortex-m33.no_dsp.no_fp flags (no floating point) but armclang uses only -mcpu=cortex-m33+nodsp (with floating point).

PR #9480 probably accidently removed the -mfpu=none flag from the compilation command, so this PR restores it.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/mbed-os-tools @deepikabhavnani

Fix cortex-m33-S armlink error
965410b 
Add "-mfpu=none" compilation flag
@mikisch81
Copy link
Contributor Author

@ARMmbed/mbed-os-maintainers

@kjbracey
Copy link
Contributor

kjbracey commented Feb 6, 2019

#9480 was trying to transfer that to a +nofp on the CPU selection, and #9606 removed that because it didn't work, without putting the -mfpu=none back.

Compiler behaviour seems rather inconsistent here...

@mikisch81
Copy link
Contributor Author

@ARMmbed/mbed-os-maintainers Is CI free?

@mikisch81
Copy link
Contributor Author

@ARMmbed/mbed-os-maintainers Is CI free?

@ARMmbed/mbed-os-maintainers @NirSonnenschein ping..

@NirSonnenschein
Copy link
Contributor

started CI

@mikisch81 mikisch81 mentioned this pull request Feb 6, 2019
Merged
@mbed-ci
Copy link

mbed-ci commented Feb 6, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@mikisch81
Copy link
Contributor Author

@NirSonnenschein CI passed, is it mergeable?

@0xc0170 0xc0170 merged commit 09db995 into ARMmbed:master Feb 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@kjbracey kjbracey kjbracey approved these changes

@NirSonnenschein NirSonnenschein NirSonnenschein approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mikisch81 @kjbracey @NirSonnenschein @mbed-ci @0xc0170