Skip to content

Fix licenses in travis test and realtek lib #9488

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jan 24, 2019
Merged

Fix licenses in travis test and realtek lib #9488

merged 3 commits into from
Jan 24, 2019

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Jan 24, 2019 •
edited
Loading

Description

81f9cda - just a revert (the license was overwritten during lib update) @ARMmbed/team-realtek please review
32e247d - phone database contains not allowed license, reverting this file @kegilbert please review (I could not find use of this file, there is isn't it - travis fill fail?). This file not yet released.

Pull request type

[X] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[ ] Breaking change

Reviewers

@ARMmbed/team-realtek @kegilbert

@0xc0170
realtek: revert license change
81f9cda 
While updating the file in the commit b06553f, the license was changed. This comimt restores the license back to the original one - Apache 2.0
@0xc0170
travis: remove phonedat database
32e247d 
Not permissive license
@0xc0170 0xc0170 changed the title Fix licenses Fix licenses in travis test and realtek lib Jan 24, 2019
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 24, 2019 •
edited
Loading

travis-ci/licence_check - this needs a fix

cc @ARMmbed/mbed-os-test (I created a new internal issue for this)

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 24, 2019

travis-ci/doxy-spellcheck — Local doxy-spellcheck testing has passed

@kegilbert phoedat not needed?

@ciarmcom ciarmcom requested review from kegilbert and a team January 24, 2019 14:00
@ciarmcom
Copy link
Member

@0xc0170, thank you for your changes.
@kegilbert @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested a review from a team January 24, 2019 14:00
@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 24, 2019

Very much needed in 5.11.3

cmonr
cmonr reviewed Jan 24, 2019
View reviewed changes
tools/test/travis-ci/doxy-spellchecker/en_phonet.dat
# touch ups by Kevin Atkinson
#
# This library is free software; you can redistribute it and/or
# modify it under the terms of the GNU Lesser General Public
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@0xc0170 This would be why the test didn't catch the problem.

The license string is split across lines, and has a # in the middle of the linebreak...
This might be interesting to fix.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kegilbert Fyi.

It looks like this file isn't needed?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If it's not needed we can remove, I had though Aspell was using it at the time but seems not to be.

@cmonr cmonr mentioned this pull request Jan 24, 2019
Merged
kegilbert
kegilbert approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@kegilbert kegilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on the removed file, doesn't appear to be used.

kegilbert
kegilbert suggested changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@kegilbert kegilbert left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just kidding! It breaks the test, but fails silently....need to fix that.

@kegilbert
Copy link
Contributor

@0xc0170 I can replace the contents of en_phonet.dat with an empty file containing the version string to keep aspell happy. Would that be ok?

@0xc0170
Copy link
Contributor Author

0xc0170 commented Jan 24, 2019

Yes, you can push to my branch to keep this PR up to date by removing license offenders

Add empty en_phonet.
ecdd1d7 
Required to run with aspell and comply with license changes
@cmonr
Copy link
Contributor

cmonr commented Jan 24, 2019

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 24, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

@cmonr cmonr merged commit 615ed31 into ARMmbed:master Jan 24, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cmonr cmonr cmonr approved these changes

@kegilbert kegilbert kegilbert approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.3
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@0xc0170 @ciarmcom @kegilbert @cmonr @mbed-ci