Skip to content

Add sd-driver example #9487

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 31, 2019
Merged

Add sd-driver example #9487

merged 1 commit into from
Jan 31, 2019

Conversation

theamirocohen
Copy link
Contributor

@theamirocohen theamirocohen commented Jan 24, 2019 •
edited by adbridge
Loading

Description

Add mbed-os-example-sd-driver to mbed-os examples.json

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[x] Test update
[ ] Breaking change

Reviewers

@0xc0170 @adbridge

@ciarmcom
Copy link
Member

@theamirocohen, thank you for your changes.
@adbridge @0xc0170 @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from 0xc0170, adbridge and a team January 24, 2019 12:00
adbridge
adbridge approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@adbridge adbridge left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

bridadan
bridadan approved these changes Jan 24, 2019
View reviewed changes
Copy link
Contributor

@bridadan bridadan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@adbridge any chance tools team can be removed from the maintainer list for this file? I think this one falls under the maintainers.

@0xc0170
Copy link
Contributor

0xc0170 commented Jan 29, 2019

@adbridge any chance tools team can be removed from the maintainer list for this file? I think this one falls under the maintainers.

Send PR please to the repo fixing this

Ci started

@mbed-ci
Copy link

mbed-ci commented Jan 29, 2019

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 1
Build artifacts

0xc0170
0xc0170 reviewed Jan 31, 2019
View reviewed changes
tools/test/examples/examples.json
@@ -163,7 +163,7 @@
"compile" : true,
"export": true,
"auto-update" : true
},
},
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For future changes, this should be in separate commit

@0xc0170 0xc0170 merged commit dbc3c62 into ARMmbed:master Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@bridadan bridadan bridadan approved these changes

@adbridge adbridge adbridge approved these changes

Assignees
No one assigned
Labels
release-version: 5.11.4
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@theamirocohen @ciarmcom @0xc0170 @mbed-ci @bridadan @adbridge @cmonr