Sleep: error flags fix

[deepikabhavnani]

Description

All the debug calls in sleep manager for sleep tracing should be changed to mbed_error_printf since most sleep API's and calls are interrupt and thread safe. PR #9260

Issue was seen only with debug profile and was not captured in develop profile because MBED_TRAP_ERRORS_ENABLED flag was not set in develop profile. Fixed here.

Pull request type

[ ] Fix
[ ] Refactor
[ ] Target update
[ ] Functionality change
[ ] Docs update
[ ] Test update
[X] Breaking change

Reviewers

@kjbracey-arm @theotherjimmy

Release notes

This change adds the MBED_TRAP_ERRORS_ENABLED flag to the develop profile. It traps on RTX errors and invalid operations in ISR context enabled in the develop profile. These errors were silent in the develop profile.
This change might result in an increase of the final binary size.

[ciarmcom]

@deepikabhavnani, thank you for your changes.
@theotherjimmy @kjbracey-arm @ARMmbed/mbed-os-tools @ARMmbed/mbed-os-maintainers please review.

[deepikabhavnani]

@ARMmbed/mbed-os-maintainers - Can we test this PR in CI (based on availability) to see the impact of newly added flags

[cmonr]

@deepikabhavnani Will look at doing that tomorrow. We still have a queue of PRs in CI for 5.11.2 will be generated tonight.

[0xc0170]

5.11.2 is still not completed (currently one more fix incoming most probably), I'll set this to needs: CI to run it through CI

[deepikabhavnani]

5.11.2 is still not completed (currently one more fix incoming most probably), I'll set this to needs: CI to run it through CI

Shall I still rebase to pick new Travis changes? Rebase done, can test as per CI availability

[cmonr]

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

[cmonr]

@theotherjimmy @kjbracey-arm Any thoughts?

@deepikabhavnani I just had a thought. This is probably going to add more debug symbols and increase binary size for debug builds, correct?

[deepikabhavnani]

@cmonr - Yes some more debug messages

mbed-os/rtos/TARGET_CORTEX/mbed_rtx_handlers.c

Line 88 in b9927e5

#if defined(MBED_TRAP_ERRORS_ENABLED) && MBED_TRAP_ERRORS_ENABLED

mbed-os/platform/mbed_wait_api_rtos.cpp

Line 56 in b9927e5

MBED_ERROR(MBED_MAKE_ERROR(MBED_MODULE_PLATFORM, MBED_ERROR_INVALID_OPERATION),

mbed-os/platform/mbed_wait_api_rtos.cpp

Line 55 in b9927e5

#if defined(MBED_TRAP_ERRORS_ENABLED) && MBED_TRAP_ERRORS_ENABLED

increase binary size for debug builds

CI runs debug builds but I don't see any size increase

[cmonr]

CI runs debug builds but I don't see any size increase

Oh. That was a welcome surprise.

[0xc0170]

Add flag "-DMBED_TRAP_ERRORS_ENABLED=1" to develop profile as well

Why is this being added to develop profile? It was not initially clear. Can you add it to the commit msg?

How is this breaking - by adding a new macro to the develop profile?

[cmonr]

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 2
Build artifacts

[NirSonnenschein]

CI has passed, but does this still needs and additional review. @kjbracey-arm @theotherjimmy could you please take a look

[deepikabhavnani]

Ready to merge?

[NirSonnenschein]

hi @deepikabhavnani , Breaking changes now need a release notes section in the description. see example here:#9568

[deepikabhavnani]

hi @deepikabhavnani , Breaking changes now need a release notes section in the description. see example here:#9568

Done. Can be reviewed by @ARMmbed/mbed-docs

[0xc0170]

The final approval waiting for @bulislaw but as he is OoO this week, @donatieng can you review instead please?

[jeromecoutant]

Ready to merge?

[0xc0170]

Ready to merge?

While waiting for final approval, running CI now as it was a week ago.

CI started

[mbed-ci]

Test run: SUCCESS

Summary: 12 of 12 test jobs passed
Build number : 3
Build artifacts

[donatieng]

Looks good to me!