-
Notifications
You must be signed in to change notification settings - Fork 3k
Create Jenkinsfile #2384
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Create Jenkinsfile #2384
Conversation
execute ("git log -1 --no-merges --pretty=format:'%H' > GIT_REVISION") | ||
env.GIT_REVISION = readFile ("GIT_REVISION") | ||
execute ("mbed deploy --protocol ssh") | ||
execute ("mbed test --compile -m ${target} -t ${toolchain} -c") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@miklis We're already running this test with 2 other CIs, we probably don't need to do it again here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think this is only way to create CI pipeline, where first stage is compile mbed-os with it's tests and continue only if them PASS... because other CI's doesn't trig this one..
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I see what you're saying, since it makes no sense for your tests to run if the OS can't even compile.
Should be fine for now 👍
@miklis Thanks for getting this back in! Sorry it was lost in the move over and here and with the release. |
mbed-client-cliapp and mbed-client-testapp are now updated to use the passed revision parameter. This enables us to test every change done to mbed-os with the test applications before merging. |
@@ -0,0 +1,67 @@ | |||
// List of targets to compile | |||
def morpheusTargets = [ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't we use just regular targets
? prefix morpheus
shall be removed?
Why there are some targets commented out ? Should not be there ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some targets and toolchains are commented as I am not sure if they are officially supported yet.
I removed all references to morpheus, using just target
now.
@miklis Can the GitHub Status name be changed to something more descriptive?
|
@bridadan Currently no, the status context is hardcoded in Jenkins when using pipeline Jenkinsfile jobs. There is an issue logged with Jenkins concerning this: https://issues.jenkins-ci.org/browse/JENKINS-36574 |
@bridadan Status context is now a bit better. I think we still don't have the option to define the context manually but at least it is now static. Another note, I am reworking the Jenkinsfiles in background. I am going to move all actual execution steps to functions in Jenkins internal dsl library and have the repository Jenkinsfiles generalized. This would also allow using single Jenkinsfile to run different builds on separate Jenkins machines. |
Moved general build execution steps to Jenkins internal DSL library.
Added Jenkinsfile for running tests for pull requests