Skip to content

Create Jenkinsfile #2384

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Sep 2, 2016
Merged

Create Jenkinsfile #2384

merged 6 commits into from
Sep 2, 2016

Conversation

miklis
Copy link
Contributor

@miklis miklis commented Aug 8, 2016

Added Jenkinsfile for running tests for pull requests

@miklis
Copy link
Contributor Author

miklis commented Aug 8, 2016

execute ("git log -1 --no-merges --pretty=format:'%H' > GIT_REVISION")
env.GIT_REVISION = readFile ("GIT_REVISION")
execute ("mbed deploy --protocol ssh")
execute ("mbed test --compile -m ${target} -t ${toolchain} -c")
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@miklis We're already running this test with 2 other CIs, we probably don't need to do it again here.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is only way to create CI pipeline, where first stage is compile mbed-os with it's tests and continue only if them PASS... because other CI's doesn't trig this one..

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I see what you're saying, since it makes no sense for your tests to run if the OS can't even compile.

Should be fine for now 👍

@bridadan
Copy link
Contributor

bridadan commented Aug 8, 2016

@miklis Thanks for getting this back in! Sorry it was lost in the move over and here and with the release.

@miklis
Copy link
Contributor Author

miklis commented Aug 9, 2016

mbed-client-cliapp and mbed-client-testapp are now updated to use the passed revision parameter. This enables us to test every change done to mbed-os with the test applications before merging.

@@ -0,0 +1,67 @@
// List of targets to compile
def morpheusTargets = [
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we use just regular targets ? prefix morpheus shall be removed?
Why there are some targets commented out ? Should not be there ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some targets and toolchains are commented as I am not sure if they are officially supported yet.

I removed all references to morpheus, using just target now.

@bridadan
Copy link
Contributor

bridadan commented Aug 9, 2016

@miklis Can the GitHub Status name be changed to something more descriptive?

Jenkins job PR-2384 tends to get lost in all the CIs we currently have running.

@miklis
Copy link
Contributor Author

miklis commented Aug 10, 2016

@bridadan Currently no, the status context is hardcoded in Jenkins when using pipeline Jenkinsfile jobs. There is an issue logged with Jenkins concerning this: https://issues.jenkins-ci.org/browse/JENKINS-36574

@miklis
Copy link
Contributor Author

miklis commented Aug 25, 2016

@bridadan Status context is now a bit better. I think we still don't have the option to define the context manually but at least it is now static. continuous-integration/jenkins/pr-merge replaces Jenkins job PR-*

Another note, I am reworking the Jenkinsfiles in background. I am going to move all actual execution steps to functions in Jenkins internal dsl library and have the repository Jenkinsfiles generalized. This would also allow using single Jenkinsfile to run different builds on separate Jenkins machines.

miklis added 2 commits August 25, 2016 16:13
Moved general build execution steps to Jenkins internal DSL library.
@sg- sg- merged commit cc3a382 into master Sep 2, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants