Skip to content

Adding test frameworks and test sources #2197

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 20, 2016

Conversation

bridadan
Copy link
Contributor

This commit adds the following test frameworks:

The following changes were made when brining these frameworks into the
tree:

  • References to mbed_drivers/mbed.h within utest's tests were migrated
    to mbed.h
  • The yotta file module.json was removed from greentea-client and
    unity
    • coverage.json was also removed from greentea-client
  • Apache 2.0 license files were removed from greentea-client

This also bringings in a number of tests that have been newly written or ported from various sources:

  • TESTS/integration - Very basic tests, used to check if testing frameworks are working correctly
  • TESTS/mbed_drivers (Thanks @PrzemekWirkus!) - TESTS ported from mbed OS 3.0 (https://github.com/ARMmbed/mbed-drivers)
  • TESTS/mbedmicro-mbed (Thanks @PrzemekWirkus!) - Tests that weren't covered by TESTS/mbed_drivers that currently live in libraries/tests/mbed
  • TESTS/mbedmicro-rtos-mbed (Thanks @PrzemekWirkus!) - Ported tests that currently live in libraries/tests/rtos/mbed
  • TESTS/storage_abstraction (Thanks @rgrover!) - Tests for the storage_abstraction hal

Please review @adbridge
FYI @sg- @0xc0170

@bridadan bridadan force-pushed the tests-and-frameworks branch from 6adbe47 to 83ef963 Compare July 20, 2016 15:43
@adbridge
Copy link
Contributor

adbridge commented Jul 20, 2016

@bridadan wrt

The following changes were made when brining these frameworks into the
tree:

    References to mbed_drivers/mbed.h within utest's tests were migrated to mbed.h
    The yotta file module.json was removed from greentea-client and unity
        coverage.json was also removed from greentea-client

This will remove Yotta support for building Morpheus, has this decision been made ? I believe there are still some groups using Yotta...

@bridadan
Copy link
Contributor Author

@adbridge This behavior was never supported in this full tree though right? Only in the module repositories. So if updates need to land here, those files can be removed in the PR.

@sg-
Copy link
Contributor

sg- commented Jul 20, 2016

LGTM 👍 Can we get some more CI running on this :)

@bridadan
Copy link
Contributor Author

I landed the frameworks in mbed/features/frameworks. Is that the right place @sg- @adbridge ?

@bridadan
Copy link
Contributor Author

@mbed-bot: TEST

HOST_OSES=windows
BUILD_TOOLCHAINS=GCC_ARM,ARM,IAR
TARGETS=K64F,LPC1768,NUCLEO_F411RE

@adbridge
Copy link
Contributor

Ran a merge tool on the frameworks directory to compare against a current checkout of mbed-os/frameworks. Changes shown match @bridadan comments .
So LGTM 👍

@adbridge
Copy link
Contributor

@bridadan mbed/features/frameworks seems reasonable to me .

@mbed-bot
Copy link

[Build 655]
SUCCESS: Building succeeded and tests were run! Be sure to check the test results

@bridadan
Copy link
Contributor Author

Ah need to remove a few .gitignore and .gitattributes files, one sec!

@sg-
Copy link
Contributor

sg- commented Jul 20, 2016

mbed/features/frameworks is a great place! Lets make sure to land the updates to static initialization or create an issue to track that if not already fixed.

This commit adds the following test frameworks:

- `greentea-client` (https://github.com/ARMmbed/greentea-client)
  - This framework provides a key-value api for communicating with the
    greentea test tool (https://github.com/ARMmbed/greentea)
- `unity` (https://github.com/ARMmbed/unity)
  - This framework provides test assert macros that can be used when
    writing test cases
- `utest` (https://github.com/ARMmbed/utest)
  - This framework allows you to execute a series of test cases with
    reporting that works with the greentea test tool
    (https://github.com/ARMmbed/greentea)

The following changes were made when bringing these frameworks into the
tree:

- References to `mbed_drivers/mbed.h` within utest's tests were migrated
  to `mbed.h`
- The yotta file `module.json` was removed from `greentea-client` and
  `unity`
  - `coverage.json` was also removed from `greentea-client`
- `.gitignore` and `.gitattributes` were removed from `greentea-client`
- Apache 2.0 license files were removed from `greentea-client`

This also brings in a number of tests that have been newly written or ported from various sources:

- `TESTS/integration` - Very basic tests, used to check if testing frameworks are working correctly
- `TESTS/mbed_drivers` (Thanks @PrzemekWirkus!) - TESTS ported from mbed OS 3.0 (https://github.com/ARMmbed/mbed-drivers)
- `TESTS/mbedmicro-mbed` (Thanks @PrzemekWirkus!) - Tests that weren't covered by `TESTS/mbed_drivers` that currently live in `libraries/tests/mbed`
- `TESTS/mbedmicro-rtos-mbed` (Thanks @PrzemekWirkus!) - Ported tests that currently live in `libraries/tests/rtos/mbed`
- `TESTS/storage_abstraction` (Thanks @rgrover!) - Tests for the storage_abstraction hal
@bridadan bridadan force-pushed the tests-and-frameworks branch from 83ef963 to a9eb39d Compare July 20, 2016 17:42
@bridadan
Copy link
Contributor Author

I have removed the .gitignore and .gitattributes from greentea-client.

@sg- Ready from my side!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants