Remove macro for operators. Enable these as default behavior #2137
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looks good to me. Why was the code switched out in the first place? |
| @@ -28,13 +28,13 @@ Note: This configuration file must be in [JSON format](http://www.w3schools.com/ | |||
| Note: Unfortunately JSON format is not allowing you to have comments inside JSON code. | |||
|
|
|||
| Let’s see some example and let's try to configure small "test farm" with three devices connected to your host computer. In this example no peripherals (like SD card or EEPROM) are connected to our Mbed boards. We will use three platforms in this example: | |||
| * [NXP LPC1768](https://mbed.org/platforms/mbed-LPC1768) board. | |||
There was a problem hiding this comment.
the whitespace removal shall be separate commit
There was a problem hiding this comment.
git commit -p will let you choose specific chunks if you just want to commit the non-whitespace changes.
|
@sg- Any description for this PR? You are changing 20 files you could drop a line or two to explain what you are trying to achieve in this PR. Thanks! |
|
@PrzemekWirkus Remove macro for operator overloading. Enable these as default behavior :) |
Pull requestPlease send pull requests with changes which are:
|
|
Any update on this? This patch shall get in, macros do not make sense to me neither. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
By default, APIs with overloaded operators are enabled. Remove the macro that was gating this but enabled by default in the header file.