Add support for Nucleo F429ZI #2077
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
|
Can you please rebase, there are conflicts |
erwango
force-pushed
the
dev_NUCLEO_F429ZI
branch
from
38927f5 to
6073e85
Compare
|
@0xc0170 , Rebase done. Hope it is fine now :-) |
| "extra_labels": ["STM", "STM32F4", "STM32F429", "STM32F429ZI"], | ||
| "supported_toolchains": ["ARM", "uARM", "GCC_ARM", "IAR"], | ||
| "progen": {"target": "nucleo-f429zi"}, | ||
| "device_has": ["ANALOGIN", "ANALOGOUT", "CAN", "ERROR_RED", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "RTC_LSI", "SERIAL", "SLEEP", "SPI", "SPISLAVE", "STDIO_MESSAGES"], |
There was a problem hiding this comment.
@unaligned device_has, please fix. tabs?
|
LGTM, waiting for travis and if you can fix that device_has indentation |
erwango
force-pushed
the
dev_NUCLEO_F429ZI
branch
from
6073e85 to
a64e16d
Compare
|
@0xc0170. Device_has identtation fixed! Thxs |
| @@ -962,7 +973,7 @@ | |||
| "extra_labels": ["STM", "STM32F4", "STM32F429", "STM32F429ZI"], | |||
| "supported_toolchains": ["ARM", "uARM", "GCC_ARM", "IAR"], | |||
| "progen": {"target": "disco-f429zi"}, | |||
| "device_has": ["ANALOGIN", "ANALOGOUT", "CAN", "ERROR_RED", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "RTC_LSI", "SERIAL", "SLEEP", "SPI", "SPISLAVE", "STDIO_MESSAGES"], | |||
| "device_has": ["ANALOGIN", "ANALOGOUT", "CAN", "ERROR_RED", "I2C", "I2CSLAVE", "INTERRUPTIN", "PORTIN", "PORTINOUT", "PORTOUT", "PWMOUT", "RTC", "RTC_LSI", "SERIAL", "SLEEP", "SPI", "SPISLAVE", "STDIO_MESSAGES"], | |||
There was a problem hiding this comment.
I can still see this unaligned line here on github.
erwango
force-pushed
the
dev_NUCLEO_F429ZI
branch
from
a64e16d to
eaf77ed
Compare
|
@0xc0170. Fixed & reviewed. Should be fine now. Thxs |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR provides support for new 144 pins target NUCLEO_F429ZI.
Full non regression performed with no outstanding issue (MBED_16 failed as per Issue #2027). Report attached. Interface pins tested OK manually : PWMOUT, ADC, DAC, SPI, I2C.
report__common__2016_06_27_14_07__NUCLEO_F429ZI__uARM_ARM_IAR_GCC.zip