Skip to content

Ambiq Micro: refactor CMake targets #14242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Feb 12, 2021
Merged

Ambiq Micro: refactor CMake targets #14242

merged 4 commits into from
Feb 12, 2021

Conversation

0xc0170
Copy link
Contributor

@0xc0170 0xc0170 commented Feb 8, 2021 •
edited
Loading

Summary of changes

Follow what we did for ST, to create separate CMake targets for each Mbed target.
I tested locally 2-3 targets for different toolchains.

Impact of changes

Migration actions required

Documentation

Pull request type 

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[x] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 8, 2021

@rwalton-arm just FYI, one of the first, we will do more this week

@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Feb 8, 2021
@ciarmcom ciarmcom requested review from a team February 8, 2021 16:00
@ciarmcom
Copy link
Member

ciarmcom commented Feb 8, 2021

@0xc0170, thank you for your changes.
@ARMmbed/team-sparkfun @ARMmbed/mbed-os-maintainers please review.

rajkan01
rajkan01 reviewed Feb 9, 2021
View reviewed changes
Copy link
Contributor

@rajkan01 rajkan01 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

hugueskamba
hugueskamba reviewed Feb 10, 2021
View reviewed changes
Copy link
Collaborator

@hugueskamba hugueskamba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The CMake targets should be renamed to follow the convention used in Mbed OS CMake files.

hugueskamba
hugueskamba previously requested changes Feb 10, 2021
View reviewed changes
targets/TARGET_Ambiq_Micro/TARGET_Apollo3/COMPONENT_lis2dh12/lis2dh12/CMakelists.txt Outdated
Comment on lines 13 to 14
COMPONENT_lis2dh12/lis2dh12/lis2dh12_platform_apollo3.c
COMPONENT_lis2dh12/lis2dh12/lis2dh12_reg.c
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
COMPONENT_lis2dh12/lis2dh12/lis2dh12_platform_apollo3.c
COMPONENT_lis2dh12/lis2dh12/lis2dh12_reg.c
lis2dh12_platform_apollo3.c
lis2dh12_reg.c

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/COMPONENT_lis2dh12/lis2dh12/CMakelists.txt Outdated
@@ -0,0 +1,17 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
# Copyright (c) 2020 ARM Limited. All rights reserved.
# Copyright (c) 2021 ARM Limited. All rights reserved.

rwalton-arm
rwalton-arm previously requested changes Feb 10, 2021
View reviewed changes
targets/TARGET_Ambiq_Micro/TARGET_Apollo3/COMPONENT_hm01b0/hm01b0/CMakelists.txt Outdated
@@ -0,0 +1,16 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/COMPONENT_lis2dh12/lis2dh12/CMakelists.txt Outdated
@@ -0,0 +1,17 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/TARGET_SFE_ARTEMIS/CMakelists.txt Outdated
@@ -0,0 +1,18 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/TARGET_SFE_ARTEMIS_ATP/CMakelists.txt Outdated
@@ -0,0 +1,18 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/TARGET_SFE_ARTEMIS_DK/CMakelists.txt Outdated
@@ -0,0 +1,18 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/TARGET_SFE_ARTEMIS_MODULE/CMakelists.txt Outdated
@@ -0,0 +1,18 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/TARGET_SFE_ARTEMIS_NANO/CMakelists.txt Outdated
@@ -0,0 +1,18 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/TARGET_SFE_ARTEMIS_THING_PLUS/CMakelists.txt Outdated
@@ -0,0 +1,18 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/TARGET_SFE_EDGE/CMakelists.txt Outdated
@@ -0,0 +1,18 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

targets/TARGET_Ambiq_Micro/TARGET_Apollo3/TARGET_SFE_EDGE2/CMakelists.txt Outdated
@@ -0,0 +1,18 @@
# Copyright (c) 2020 ARM Limited. All rights reserved.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

File name should be CMakeLists.txt

@0xc0170
Ambiq Micro: refactor CMake targets
efbf0bb 
Follow what we did for ST, to create separate CMake targets for each Mbed target.
@0xc0170
CMake Ambiq Micro: fix naming
b4f0be1
@0xc0170 0xc0170 force-pushed the cmake-refactor-ambiq-micro branch from fce0a82 to b4f0be1 Compare February 11, 2021 14:09
@mergify mergify bot dismissed stale reviews from hugueskamba and rwalton-arm February 11, 2021 14:10

Pull request has been modified.

@0xc0170
Copy link
Contributor Author

0xc0170 commented Feb 11, 2021

Fixed the names and also the copyright year

@mergify mergify bot added needs: CI and removed needs: review labels Feb 11, 2021
@mbed-ci
Copy link

mbed-ci commented Feb 11, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@mergify mergify bot removed the needs: CI label Feb 11, 2021
@0xc0170 0xc0170 merged commit d041654 into ARMmbed:master Feb 12, 2021
@0xc0170 0xc0170 deleted the cmake-refactor-ambiq-micro branch February 12, 2021 09:16
@mergify mergify bot removed the ready for merge label Feb 12, 2021
@mbedmain mbedmain added release-version: 6.8.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Feb 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rajkan01 rajkan01 rajkan01 left review comments

@hugueskamba hugueskamba hugueskamba approved these changes

@rwalton-arm rwalton-arm rwalton-arm left review comments

Assignees
No one assigned
Labels
release-version: 6.8.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@0xc0170 @ciarmcom @mbed-ci @hugueskamba @rwalton-arm @rajkan01 @mbedmain