Skip to content

STM32H7: disable uSD transceiver #14145

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jan 18, 2021
Merged

STM32H7: disable uSD transceiver #14145

merged 1 commit into from
Jan 18, 2021

Conversation

pennam
Copy link
Contributor

@pennam pennam commented Jan 13, 2021 •
edited by 0xc0170
Loading

Summary of changes

This pull request disable uSD transceiver in STM32H7 boards

Impact of changes

STM32H7 family

Migration actions required

Documentation

Pull request type 

[X] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@jeromecoutant @facchinm

@pennam pennam mentioned this pull request Jan 13, 2021
Closed
@ciarmcom
Copy link
Member

@pennam, thank you for your changes.
@jeromecoutant @ARMmbed/team-st-mcd @ARMmbed/mbed-os-maintainers please review.

@ciarmcom ciarmcom requested review from jeromecoutant and a team January 13, 2021 09:30
jeromecoutant
jeromecoutant reviewed Jan 13, 2021
View reviewed changes
Copy link
Collaborator

@jeromecoutant jeromecoutant left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

To be honest, you can remove patches in json files,
and just set USE_SD_TRANSCEIVER to 0 in stm32h7xx_hal_conf.h

@pennam pennam closed this Jan 13, 2021
@pennam pennam force-pushed the config_sd_transceiver branch from 6fb57e4 to 2255408 Compare January 13, 2021 10:11
@jeromecoutant
Copy link
Collaborator

No more patch in stm32h7xx_hal_conf.h ?

@pennam pennam reopened this Jan 13, 2021
@pennam
Copy link
Contributor Author

pennam commented Jan 13, 2021

my fault, should be ok now.

@pennam pennam changed the title STM32H7: USE_SD_TRANSCEIVER is configurable STM32H7: disable uSD transceiver Jan 13, 2021
@jeromecoutant
Copy link
Collaborator

ST_INTERNAL_REF 99400

@ciarmcom ciarmcom requested review from jeromecoutant and a team January 13, 2021 10:30
@ciarmcom
Copy link
Member

@pennam, thank you for your changes.
@jeromecoutant @ARMmbed/team-st-mcd @ARMmbed/mbed-os-maintainers please review.

@mergify mergify bot added needs: CI and removed needs: review labels Jan 13, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 15, 2021

CI started

@mbed-ci
Copy link

mbed-ci commented Jan 15, 2021

Jenkins CI Test : ✔️ SUCCESS

Build Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_cmake-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_build-example-ARM ✔️
jenkins-ci/mbed-os-ci_build-greentea-ARM ✔️
jenkins-ci/mbed-os-ci_build-cloud-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_cmake-example-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_cmake-example-test ✔️

@0xc0170 0xc0170 merged commit 95a524a into ARMmbed:master Jan 18, 2021
@mergify mergify bot removed the ready for merge label Jan 18, 2021
@0xc0170 0xc0170 added release-type: patch Indentifies a PR as containing just a patch and removed release-type: feature labels Jan 18, 2021
@0xc0170
Copy link
Contributor

0xc0170 commented Jan 18, 2021

Set to patch release (target update)

@mbedmain mbedmain added release-version: 6.7.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Jan 25, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0xc0170 0xc0170 0xc0170 approved these changes

@jeromecoutant jeromecoutant jeromecoutant approved these changes

Assignees
No one assigned
Labels
release-version: 6.7.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@pennam @ciarmcom @jeromecoutant @0xc0170 @mbed-ci @mbedmain