Skip to content

PSA - Generate root of trust before accessing kvstore #13594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Sep 11, 2020

Conversation

moshe-shahar
Copy link
Contributor

@moshe-shahar moshe-shahar commented Sep 10, 2020

Summary of changes

Tests and applications that use PSA, not have to generate ROT before calling PSA APIs

  1. Fix PSA to generate root of trust before accessing kvstore.
    • An application that uses PSA should not be aware of how it's implemented. Therefore, let PSA handle kvstore requirements such as generating ROT.
  2. Fix a minor issue that after calling psa_ps_reset, the version was not written again.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[x] Tested locally. Results will be supplied as part of this PR on Sunday.

Reviewers


@mergify
Copy link

mergify bot commented Sep 10, 2020

This PR cannot be merged due to conflicts. Please rebase to resolve them.

@mergify mergify bot added the needs: work label Sep 10, 2020
@ciarmcom
Copy link
Member

@moshe-shahar, thank you for your changes.
@ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

@yogpan01
Copy link
Contributor

@0xc0170 This PR is required to enable PDMC support for PSA targets on mbed OS 6 onwards.

@adbridge
Copy link
Contributor

@moshe-shahar could you please address the review comments and also fill in the test section in the header

@adbridge
Copy link
Contributor

I'll run the CI in the meantime

@adbridge
Copy link
Contributor

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 11, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage ✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest ✔️

@adbridge adbridge merged commit ad973f2 into ARMmbed:master Sep 11, 2020
@adbridge adbridge added release-type: patch Indentifies a PR as containing just a patch and removed mergify skip needs: work labels Sep 11, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants