travis: license check for new files #13586
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ciarmcom
added
the
release-type: patch
|
@0xc0170, thank you for your changes. |
0xc0170
force-pushed
the
fix_travis_new_files
branch
from
ebec495 to
2a03918
Compare
0xc0170
changed the title
|
@adbridge Please review (see the failures), it works as expected. I'll rebase and squash once reviewed to let this green. |
adbridge
previously approved these changes
Sep 15, 2020
Fail if new file does not contain SPDX identifier. We only checked for changed files, and warn if any found. This is not sufficient because new files should follow our license guide. This fixes the problem.
0xc0170
force-pushed
the
fix_travis_new_files
branch
from
dfee8a2 to
36bb124
Compare
|
Rebased to squash the commits and remove testing commits. Ready for CI |
mergify
bot
dismissed
adbridge’s stale review
Pull request has been modified.
|
CI started |
|
@adbridge if approved, please merge. I'll rebase and fix the other pull request related to Travis I created yesterday. |
adbridge
approved these changes
Sep 17, 2020
mbedmain
added
release-version: 6.4.0
Release-pending
and removed
release-type: patch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of changes
We only warned about SPDX identifiers. We should error if new file is not properly licensed. I added travis check for new files and exclude from the current check. Thus we run 2 checks within one status. we warn for modified files (still clean up required) and error for new files.
I'll test some commits to verify this works. If this works, I can apply the same to astyle - also for new files it is mandatory to be following our style (3rd party could be added to astyleignore).
Impact of changes
Migration actions required
Documentation
Pull request type
Test results
Reviewers