Skip to content

Remove duplicate mbed-os/TESTS/host_tests scripts #13546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 7, 2020

Conversation

rajkan01
Copy link
Contributor

@rajkan01 rajkan01 commented Sep 3, 2020

Summary of changes

preceding PR #13501

  • Removed duplicate mbed-os/TESTS/host_tests scripts as it was already copied into respective libraries hosts_tests directory

Impact of changes

None.

Migration actions required

None.

Documentation

None.


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

@evedon @LDong-Arm


@rajkan01 rajkan01 changed the title Remove duplicate and move usb host tests script closure to the library Remove duplicate mbed-os/TESTS/host_tests scripts Sep 3, 2020
@ciarmcom ciarmcom added the release-type: patch Indentifies a PR as containing just a patch label Sep 3, 2020
@ciarmcom ciarmcom requested review from evedon, LDong-Arm and a team September 3, 2020 17:30
@ciarmcom
Copy link
Member

ciarmcom commented Sep 3, 2020

@rajkan01, thank you for your changes.
@LDong-Arm @evedon @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

Copy link
Contributor

@evedon evedon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why does it look like you moved some files? Do you need to rebase your PR?

@LDong-Arm
Copy link
Contributor

Why does it look like you moved some files? Do you need to rebase your PR?

They are due to the preceding PR: #13501

evedon
evedon previously approved these changes Sep 7, 2020
@mergify mergify bot added needs: CI and removed needs: review labels Sep 7, 2020
@rajkan01 rajkan01 force-pushed the remove_host_tests_script branch from 936b21d to a63d5d8 Compare September 7, 2020 09:18
@mergify mergify bot dismissed evedon’s stale review September 7, 2020 09:18

Pull request has been modified.

@rajkan01 rajkan01 force-pushed the remove_host_tests_script branch from a63d5d8 to 8ee029c Compare September 7, 2020 09:20
@rajkan01
Copy link
Contributor Author

rajkan01 commented Sep 7, 2020

@0xc0170 Could you review and start the CI

@0xc0170
Copy link
Contributor

0xc0170 commented Sep 7, 2020

CI started

@mbed-ci
Copy link

mbed-ci commented Sep 7, 2020

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs Status
jenkins-ci/mbed-os-ci_unittests ✔️
jenkins-ci/mbed-os-ci_build-ARM ✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM ✔️
jenkins-ci/mbed-os-ci_greentea-test ✔️

@0xc0170 0xc0170 merged commit 7f60090 into ARMmbed:master Sep 7, 2020
@mergify mergify bot removed the ready for merge label Sep 7, 2020
@mbedmain mbedmain added release-version: 6.3.0 Release-pending and removed release-type: patch Indentifies a PR as containing just a patch Release-pending labels Sep 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants