Fix pwm out resets after suspend

[talorion]

Summary of changes

Fixed a Problem where PwmOut resets settings after suspend.
The problem is described here: #13480

Impact of changes

Fixes: #13480

Migration actions required

Documentation

None

Pull request type

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[x] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

---

Test results

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

---

Reviewers

---

[ciarmcom]

@talorion, thank you for your changes.
@toyowata @bentcooke @maclobdell @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-core @ARMmbed/mbed-os-maintainers please review.

[0xc0170]

Thanks @talorion . Lot of work done here to update all the targets.

Fixed a Problem where PwmOut resets settings after suspend.

Can you describe how this is fixing it ? I see here adding new methods to PWMOut object.The description should describe the problem this is fixing.

This should be rather a new feature (adding new functionality), although it fixes the issue, feature addition is more important here. Please update the above template.

The previous suggestion was start/stop option, how does this compare (providing read methods instead to be able to write back?).

[talorion]

Thanks @talorion . Lot of work done here to update all the targets.

Fixed a Problem where PwmOut resets settings after suspend.

Can you describe how this is fixing it ? I see here adding new methods to PWMOut object.The description should describe the problem this is fixing.

This should be rather a new feature (adding new functionality), although it fixes the issue, feature addition is more important here. Please update the above template.

The previous suggestion was start/stop option, how does this compare (providing read methods instead to be able to write back?).

@0xc0170
PwmOut provides the methods PwmOut::suspend and PwmOut::resume
in the current implementation only the duty cycle is saved in PwmOut::suspend to be rewritten in PwmOut::resume
depending on the implementation of the PWM this can lead to problems like that the duty cycle stays the same but the period is reset to its initial state.

such a problem is described in #13480

the problem is very dependent on the implementation if just the duty cycle is given. So the simplest solution for me was to add methods to the pwmout_api that read the period in additon to the duty cycle, so it can be saved and set in PwmOut::suspend and PwmOut::resume.

[mergify]

This PR cannot be merged due to conflicts. Please rebase to resolve them.

[talorion]

@talorion Many thanks for your work. PR looks good apart from some variable names. I'm approving but please fix those.

i changed the variable names

[talorion]

@stevew817 I fixed the order of operations

[kyle-cypress]

The changes in TARGET_Cypress look good to me.

[0xc0170]

I started CI, I'll review meanwhile

[mbed-ci]

Jenkins CI Test : ✔️ SUCCESS

Build Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & Artifacts

CLICK for Detailed Summary

jobs	Status
jenkins-ci/mbed-os-ci_unittests	✔️
jenkins-ci/mbed-os-ci_build-GCC_ARM	✔️
jenkins-ci/mbed-os-ci_build-ARM	✔️
jenkins-ci/mbed-os-ci_dynamic-memory-usage	✔️
jenkins-ci/mbed-os-ci_greentea-test	✔️
jenkins-ci/mbed-os-ci_cloud-client-pytest	✔️

[0xc0170]

I've set this to "Feature" as it adds new API (to drivers/hal).