-
Notifications
You must be signed in to change notification settings - Fork 3k
Refactoring \lorawan --> moving it inside \connectivity. #13410
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@ashok-rao, thank you for your changes. |
connectivity/lorawan/tests/UNITTESTS/loramacchannelplan/unittest.cmake
Outdated
Show resolved
Hide resolved
connectivity/lorawan/tests/UNITTESTS/loramaccommand/unittest.cmake
Outdated
Show resolved
Hide resolved
connectivity/lorawan/tests/UNITTESTS/loramaccrypto/unittest.cmake
Outdated
Show resolved
Hide resolved
connectivity/lorawan/tests/UNITTESTS/loraphykr920/unittest.cmake
Outdated
Show resolved
Hide resolved
connectivity/lorawan/tests/UNITTESTS/loraphyus915/unittest.cmake
Outdated
Show resolved
Hide resolved
connectivity/lorawan/tests/UNITTESTS/lorawaninterface/unittest.cmake
Outdated
Show resolved
Hide resolved
connectivity/lorawan/tests/UNITTESTS/lorawanstack/unittest.cmake
Outdated
Show resolved
Hide resolved
connectivity/lorawan/tests/UNITTESTS/lorawantimer/unittest.cmake
Outdated
Show resolved
Hide resolved
Also, |
Here comes a question: Anyway, it's beyond the scope of this PR which looks good to me apart from my inline remark. @ashok-rao |
Reveiw comments addressed, thanks @LDong-Arm 👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
The problem is with mbed-os 5.15 -branch. As it doesn't have drivers yet, so if someone wants to use lora example with that, standalone repository must be used for drivers. At the time drivers were requested to be included in mbed-os, 6.0 was not out yet. So as example now used mbed-os 6, it should be now modified to use drivers from mbed-os instead of standalone repository. |
I modified example to use drivers from mbed-os instead of separate repository: ARMmbed/mbed-os-example-lorawan@38536b2 |
Thanks @kivaisan , this means this is unblocked now (the example will work with 6.x and 5.15.x) |
This PR cannot be merged due to conflicts. Please rebase to resolve them. |
One of the latest PRs (mbed tls restructure was it?) made a conflict in unittests, please resolve |
``` connectivity ├── netsocket ├── lorawan │ ├── mbed_lib.json // nanostack-interface's mbed_lib.json │ ├── lorastack │ ├── tests ├── nanostack ├── cellular ├── ... ``` This PR is a part of a wider \connectivity refactoring and implements the above new directory structure for \lorawan.
…ed API and missing header
…ased on new component structure
1. Moving lora drivers from \components\lora to \connectivity\drivers\lora 2. Incorporating review comments.
ef64ac1
to
9977da6
Compare
Rebased and force pushed.. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Still LGTM after the rebase
CI restarted |
Unittest failed right away |
Jenkins CI Test : ❌ FAILEDBuild Number: 1 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@0xc0170 I fixed the UNITTESTS failure, could you re-start the CI |
CI restarted |
Jenkins CI Test : ✔️ SUCCESSBuild Number: 2 | 🔒 Jenkins CI Job | 🌐 Logs & ArtifactsCLICK for Detailed Summary
|
@0xc0170 CI passed for this PR, please merge |
Summary of changes
Mbed OS will soon be changing directory structure to the below:
This PR is a part of a wider \connectivity refactoring and implements the above new directory structure for \lorawan.
Todo:
- Move \components\lora ---> \connectivity\lorawan\driversDone as part of commit
7e2d1ef8
Impact of changes
-None-
Migration actions required
-None-
Documentation
-None-
Pull request type
Test results
Build successes:
Reviewers
@LDong-Arm @gpsimenos @rajkan01