Skip to content

802.15.4 STM S2LP driver update #12876

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
May 4, 2020
Merged

802.15.4 STM S2LP driver update #12876

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 7 additions & 4 deletions components/802.15.4_RF/stm-s2lp-rf-driver/mbed_lib.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,10 +5,13 @@
"help": "Provide default NanostackRfpy. [true/false]",
"value": false
},
"target_overrides": {
"MTB_STM_S2LP": {
"s2lp.provide-default": true
}
"target_overrides": {
"MTB_STM_S2LP": {
"s2lp.provide-default": true
},
"MTB_STM_S2LP_CT": {
"s2lp.provide-default": true
}
}
}
}
2 changes: 1 addition & 1 deletion components/802.15.4_RF/stm-s2lp-rf-driver/stm-s2lp-rf-driver/NanostackRfPhys2lp.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@
// Uncomment to use testing gpios attached to TX/RX processes
// #define TEST_GPIOS_ENABLED

#if defined(TARGET_MTB_STM_S2LP)
#if defined(TARGET_MTB_STM_S2LP) || defined(TARGET_MTB_STM_S2LP_CT)
#if !defined(S2LP_SPI_SDI)
Copy link

@MarceloSalazar MarceloSalazar Apr 28, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe we shouldn't add custom configuration/defines to the drivers.
Instead, please use mbed_app.json to configure pin config in the application - this will let us remove target dependencies in Mbed OS.
See example for esp8266-driver

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@MarceloSalazar , can configuration/define change be done in another PR?
We would like to enable custom target first to verify we get target to our CI correctly. When that phase is completed we could continue with additional optimisation.

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You certainly can, but we need to move away from custom config in drivers asap and this file will be modified again. Every PR requires review, testing and time ;-)

@0xc0170 let us know if you think we can proceed as it's

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As it is already there , lets get this in and will be fixed - @artokin can you create a tracking issue for this ?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, the issue is: https://jira.arm.com/browse/IOTTHD-4097

#define S2LP_SPI_SDI PA_7
#endif
Expand Down