Skip to content

Remove unsupported targets #12864

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 52 commits into from
Apr 30, 2020
Merged

Remove unsupported targets #12864

merged 52 commits into from
Apr 30, 2020

Conversation

MarceloSalazar
Copy link

@MarceloSalazar MarceloSalazar commented Apr 24, 2020 •
edited
Loading

Summary of changes

This is the third of a series of PRs (others #12775, #12810) to remove targets that are not supported or retired as explained in recent blog post.

There are individual commits to remove targets from targets.json and files/folders for the corresponding targets.

Impact of changes

The following targets are being removed:

  • Delta: DELTA_DFBM_NQ620, DELTA_DFCM_NNN50, DELTA_DFCM_NNN40
  • NXP: LPC4088, LPC1124, LPC1347, LPC1769, LPC1549, XBED_1768
  • NXP: LPC810, LPC1800, LPC4330, LPC4337, LPC11U37H_401
  • NXP: KL26Z, KW24D, KL20D50, KL82Z, KL05Z
  • Silabs EFM32LG, EFM32WG, EFM32HG, EFM32ZG, EFM32PG, EFM32PG12, EFR32MG1
  • Advantech MTB_ADV_WISE_1570, 1510 (renamed)
  • WALLBOT_BLE, NRF51_DONGLE, NRF51822_Y5_MBUG
  • Maxim: MAXWSNENV, MAX32625NEXPAQ
  • Multitech: MTS_MDOT_F405RG, MTS_GAMBIT
  • Onsemi: NCS36510
  • Switch Science: HRM1017, TY51822R3, SSCI824 (PR Remove HRM1017, TY51822R3, SSCI824 files. #12697)
  • Ublox EVK_NINA_B1, EVA_NINA, HI2110
  • Other: RBLAB, SDT51822, RAPIDIOT, MTM_MTCONNECT04S

Migration actions required

  • The targets listed above continue to be available in the 5.15 branch.

Documentation

  • None.
    We'll update os.mbed.com/platforms with the list of supported platforms for Mbed 6

Pull request type 

[] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[X] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results 

[] No Tests required for this change (E.g docs only update)
[X] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Expect regressions tests to be done by CI as part of this PR.

Reviewers

@ARMmbed/mbed-os-maintainers

@MarceloSalazar
Copy link
Author

MarceloSalazar commented Apr 24, 2020 •
edited
Loading

Note this is work in progress

@MarceloSalazar MarceloSalazar mentioned this pull request Apr 24, 2020
Closed
@mergify mergify bot added the needs: work label Apr 24, 2020
@ciarmcom ciarmcom requested review from maclobdell and a team April 24, 2020 17:00
@ciarmcom
Copy link
Member

@MarceloSalazar, thank you for your changes.
@maclobdell @ARMmbed/mbed-os-mesh @ARMmbed/mbed-os-test @ARMmbed/mbed-os-maintainers @ARMmbed/mbed-os-storage @ARMmbed/mbed-os-crypto @ARMmbed/mbed-os-hal @ARMmbed/mbed-os-ipcore @ARMmbed/mbed-os-tools please review.

@mergify mergify bot removed the needs: review label Apr 24, 2020
@MarceloSalazar MarceloSalazar mentioned this pull request Apr 27, 2020
Closed
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 28, 2020

We also should modify CI PR config (if any target being removed is not used , so will fail to build or test).

cc @ARMmbed/mbed-os-test

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 28, 2020

Littlefs Travis job needs an update (fails with Could not compile for K82F: No Linker Script found )

@MarceloSalazar
Copy link
Author

@0xc0170 I was meant to remove K82Z only, but not K82F! I'll fix this soon.

@MarceloSalazar
Copy link
Author

@0xc0170 issue fixed and many targets removed, so I think we're ready for a review and testing :)

@MarceloSalazar
Copy link
Author

FYI @ARMmbed/team-nxp @ARMmbed/team-silabs @ARMmbed/team-advantech @ARMmbed/team-maximintegrated @ARMmbed/team-multitech @ARMmbed/team-onsemi @ARMmbed/team-switchscience @ARMmbed/team-ublox
FYI @maclobdell @toyowata @soleilplanet

@0xc0170 0xc0170 removed the request for review from a team April 29, 2020 13:12
0xc0170
0xc0170 previously approved these changes Apr 29, 2020
View reviewed changes
Copy link
Contributor

@0xc0170 0xc0170 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nanostack changes should be sent upstream as well

cc @artokin

@0xc0170 0xc0170 removed the request for review from a team April 29, 2020 14:16
@mergify mergify bot added needs: CI and removed needs: review labels Apr 29, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 29, 2020

I started CI prior realizing this needs a rebase. CI aborted

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2020

CI restarted

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2020

Test run: FAILED

Summary: 4 of 7 test jobs failed
Build number : 3
Build artifacts

Failed test jobs:

  • jenkins-ci/mbed-os-ci_dynamic-memory-usage
  • jenkins-ci/mbed-os-ci_cloud-client-pytest
  • jenkins-ci/mbed-os-ci_wisun-mesh-test
  • jenkins-ci/mbed-os-ci_greentea-test

@mbed-ci
Copy link

mbed-ci commented Apr 30, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 4
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2020

I am checking why Travis has not updated the status

@0xc0170 0xc0170 requested a review from bulislaw April 30, 2020 11:09
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2020

I'll close this for a minute and hopefully travis picks up the latest force push. I found there only older sha.

@0xc0170 0xc0170 closed this Apr 30, 2020
@0xc0170 0xc0170 reopened this Apr 30, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Apr 30, 2020

Travis soon will be completed, and I'll merge this one

@0xc0170 0xc0170 merged commit 08a0920 into ARMmbed:master Apr 30, 2020
@mergify mergify bot removed the ready for merge label Apr 30, 2020
@amq
Copy link
Contributor

amq commented May 4, 2020 •
edited
Loading

I think EFM32PG12 was removed by mistake, possibly thinking that it is a variant of EFM32PG. It's also not mentioned in the PR description.

EFM32PG12 is recommended for new designs and it doesn't match any of the criteria mentioned in the blog post. It supports all of the recent functionality like bootloader, TRNG, LPTICKER etc. We also use it commercially with Mbed OS.

@MarceloSalazar @0xc0170 @stevew817

@MarceloSalazar MarceloSalazar deleted the platform_cleanup3 branch May 5, 2020 07:22
@MarceloSalazar
Copy link
Author

@amq the target EFM32PG12 is not Mbed Enabled and was removed as planned. I'll update this PR.
Note it continues to be supported in the 5.15 branch.

@ARMmbed/team-silabs may consider re-introducing in Mbed OS 6 in the future.

@0xc0170
Copy link
Contributor

0xc0170 commented May 5, 2020

@amq please use custom target for EFM32PG12 coming from the latest revision that was on master. More details will follow

This was referenced May 6, 2020
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bulislaw bulislaw bulislaw approved these changes

@0xc0170 0xc0170 0xc0170 approved these changes

@maclobdell maclobdell Awaiting requested review from maclobdell

Assignees
No one assigned
Labels
BREAKING-CHANGE release-version: 6.0.0-beta-1
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@MarceloSalazar @ciarmcom @0xc0170 @mbed-ci @amq @bulislaw