Skip to content

Cordio: fix for issue #12625 #12637

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Mar 23, 2020
Merged

Conversation

vishalbharg
Copy link
Contributor

@vishalbharg vishalbharg commented Mar 17, 2020

Summary of changes

This fix is related to Mbed OS issue
#12625

This issue is related to WSF memory corruption when device send a complete HCI ACL packet to the transport. But fragmented packet case is not handled & WSF memory free is not happening, and later WSF memory (logic) corrupt which makes hard fault in OS.

Impact of changes

Migration actions required

Documentation


Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers


Handled fragmented packet case also.
Indent formating
@ciarmcom ciarmcom requested review from a team March 17, 2020 08:00
@ciarmcom
Copy link
Member

@vishalbharg, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

@adbridge
Copy link
Contributor

@vishalbharg it looks like you changed the format of the PR template (removing header markers and section delimiters). Could you please not do this as it affects how our automated tools parse the content. PRs should look like this one #12662
Could you please restructure the PR header back to how it should be ? Thanks

@vishalbharg
Copy link
Contributor Author

@adbridge done (according to #12662), Thanks

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

@ARMmbed/mbed-os-pan Please review

@0xc0170 0xc0170 changed the title #12625 ble cardio patch Cordio: fix for issue #12625 Mar 23, 2020
@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

Started CI meanwhile

@mbed-ci
Copy link

mbed-ci commented Mar 23, 2020

Test run: SUCCESS

Summary: 7 of 7 test jobs passed
Build number : 1
Build artifacts

@0xc0170
Copy link
Contributor

0xc0170 commented Mar 23, 2020

Waiting for the final reviews

@paul-szczepanek-arm
Copy link
Member

paul-szczepanek-arm commented Mar 23, 2020

This means the zero copy HCI will also need fixing nevermind, zero copy does not have fragmentation so it's OK but it should have assert to make sure there's no HCI limit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants