STM32WB : update BLE part with better support #12384

jeromecoutant · 2020-02-06T17:16:42Z

Summary of changes

Few update around STM32WB BLE support:

debug logs is unified with mbed-trace method
BLE FW version is available in the logs when enabled
a readme file is added to help customers to understand, use and debug BLE part

@LMESTM
@donatieng

Regards,

Impact of changes

Migration actions required

Documentation

Pull request type

[x] Patch update (Bug fix / Target update / Docs update / Test update / Refactor)
[] Feature update (New feature / Functionality change / New API)
[] Major update (Breaking change E.g. Return code change / API behaviour change)

Test results

[] No Tests required for this change (E.g docs only update)
[x] Covered by existing mbed-os tests (Greentea or Unittest)
[] Tests / results supplied as part of this PR

Reviewers

ciarmcom · 2020-02-06T18:00:41Z

@jeromecoutant, thank you for your changes.
@ARMmbed/mbed-os-pan @ARMmbed/mbed-os-maintainers please review.

0xc0170 · 2020-02-10T16:14:00Z

I restarted Travis, later saw astyle failing. Please review once completed

bulislaw

@ARMmbed/mbed-os-pan please have a look

donatieng

Thank you @jeromecoutan! A couple of nits but looks good - I'll test it on our end once these are addressed.
Great to see the README too.

donatieng · 2020-02-11T17:16:18Z

targets/TARGET_STM/TARGET_STM32WB/TARGET_STM32WB55xx/TARGET_NUCLEO_WB55RG/system_clock.c

 #include "otp.h"
-#include "hw_conf.h" /* Common BLE file where BLE shared resources are defined */
+// #include "hw_conf.h" /* Common BLE file where BLE shared resources are defined */


Should this just be removed?

donatieng · 2020-02-11T17:20:49Z

targets/TARGET_STM/TARGET_STM32WB/wb_sleep.c

-#include "sleep_api.h"
-#include "us_ticker_api.h"
-#include "us_ticker_data.h"
+// #include "sleep_api.h"


donatieng · 2020-02-11T17:24:04Z

targets/TARGET_STM/TARGET_STM32WB/README.md

+https://github.com/STMicroelectronics/STM32CubeWB/blob/master/how_to_program_wireless_stacks.txt
+
+Latest BLE FW :
+https://github.com/STMicroelectronics/STM32CubeWB/blob/master/Projects/STM32WB_Copro_Wireless_Binaries/stm32wb5x_BLE_Stack_fw.bin


Should we point the users to the LL-only version of the Wireless firmware (as we're using Cordio as the BLE stack)?
https://github.com/STMicroelectronics/STM32CubeWB/blob/master/Projects/STM32WB_Copro_Wireless_Binaries/stm32wb5x_BLE_HCILayer_fw.bin

Let's discuss it with @LMESTM
Yes, HCILayer binary file should be sufficient for mbed-os application, but I never tested it...

The current mbed code (cordio on top of HCI) can work with the 2 firmware version;; HCILayer or full stack. so yes we can point to users that they can use the HCI only version if they wish to. Nevertheless they will have to change the memory map on their own to benefit from the flash savings. I'd rather not change this memory map by default to avoid people to get first negative impression in case they try mbed with the default firmware and this doesn't work out of the box ...

Pull request has been modified.

LMESTM

Looks good to me - good clean-up !

LMESTM · 2020-02-12T13:31:52Z

targets/TARGET_STM/TARGET_STM32WB/wb_sleep.c

-
-    return;
-}
+extern int mbed_sdk_inited;


does it remove a warning ?

0xc0170 · 2020-02-13T14:37:53Z

Started CI meanwhile

mbed-ci · 2020-02-13T16:52:18Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 1
Build artifacts

donatieng

Thanks @jeromecoutant.

I'd just like to emphasize that it would be very valuable to have the "Link Layer only" option working out of the box, especially as an application pulling in the full stack will need to reserve 324 kB of flash (162kB x2 as we need to reserve the same amount of Flash to update it), which would only leave 188kB free for the app when using a part with 512 kB of Flash.
This would compare to reserving 190 kB (95 kB x2) leaving 322 kB for the app if using the LL only binary.

LMESTM · 2020-02-18T15:50:45Z

@donatieng What do you mean to have the LL option would work out of the box ?
If anyone updates the default production BLE firmware and replaces it with the LL only option, this will work without any change to the mbed-os application - so what would you like to do on top of that ?

donatieng · 2020-02-19T11:33:59Z

@LMESTM I was referring to the memory map changes you are mentioning - the way I understand it the user would have to make these changes manually?

LMESTM · 2020-02-19T12:29:13Z

@donatieng yes the memory map change would have to be done manually - I am not sure how to make this transparent ...

mergify · 2020-02-19T14:33:33Z

This PR cannot be merged due to conflicts. Please rebase to resolve them.

0xc0170 · 2020-02-19T15:15:26Z

@jeromecoutant Once rebase we run the CI

Help on FW update procedure

Pull request has been modified.

jeromecoutant · 2020-02-20T08:22:08Z

@jeromecoutant Once rebase we run the CI

Done

0xc0170 · 2020-02-21T08:05:38Z

CI started

mbed-ci · 2020-02-21T09:28:55Z

Test run: SUCCESS

Summary: 11 of 11 test jobs passed
Build number : 2
Build artifacts

jeromecoutant changed the title ~~STM32WB~~ STM32WB : update BLE part with better support Feb 6, 2020

ciarmcom requested review from a team February 6, 2020 18:00

ciarmcom added the needs: review label Feb 6, 2020

jeromecoutant mentioned this pull request Feb 10, 2020

STM32WB55xG Flash data size configuration #12343

Closed

bulislaw previously approved these changes Feb 11, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Feb 11, 2020

donatieng previously requested changes Feb 11, 2020

View reviewed changes

mergify bot added needs: work and removed needs: CI labels Feb 11, 2020

jeromecoutant force-pushed the PR_WBDEBUG branch from 94fcc4c to 72c9352 Compare February 12, 2020 10:53

0xc0170 added needs: review and removed needs: work labels Feb 12, 2020

0xc0170 requested review from donatieng and LMESTM February 12, 2020 13:17

LMESTM approved these changes Feb 12, 2020

View reviewed changes

0xc0170 previously approved these changes Feb 13, 2020

View reviewed changes

mergify bot added needs: CI and removed needs: review labels Feb 13, 2020

mergify bot added ready for merge and removed needs: CI labels Feb 13, 2020

0xc0170 added needs: review and removed ready for merge labels Feb 14, 2020

donatieng previously approved these changes Feb 18, 2020

View reviewed changes

mergify bot added the needs: work label Feb 19, 2020

mergify bot removed the needs: review label Feb 19, 2020

0xc0170 added release-version: 6.0.0-alpha-3 and removed release-version: 6.0.0-alpha-2 Second pre-release version of 6.0.0 labels Feb 19, 2020

jeromecoutant added 5 commits February 20, 2020 09:20

STM32WB HCIDriver trace update

55b42a6

STM32WB BLE : add FW version when trace is enabled

f037022

STM32WB align deepsleep functions with CubeFW

ebae0e5

STM32WB clean SetSysClock

9d01602

STM32WB : Add ReadMe file

a1570f9

Help on FW update procedure

jeromecoutant force-pushed the PR_WBDEBUG branch from 72c9352 to a1570f9 Compare February 20, 2020 08:21

0xc0170 added needs: CI and removed needs: work labels Feb 21, 2020

0xc0170 approved these changes Feb 21, 2020

View reviewed changes

mergify bot added ready for merge and removed needs: CI labels Feb 21, 2020

0xc0170 merged commit 72b2fcf into ARMmbed:master Feb 21, 2020

mergify bot removed the ready for merge label Feb 21, 2020

jeromecoutant deleted the PR_WBDEBUG branch March 2, 2020 09:33

jeromecoutant mentioned this pull request May 26, 2020

STM32WB55 RTC does not retain time #12891

Closed

STM32WB : update BLE part with better support #12384

STM32WB : update BLE part with better support #12384

Uh oh!

Conversation

jeromecoutant commented Feb 6, 2020

Summary of changes

Impact of changes

Migration actions required

Documentation

Pull request type

Test results

Reviewers

Uh oh!

ciarmcom commented Feb 6, 2020

Uh oh!

0xc0170 commented Feb 10, 2020

Uh oh!

bulislaw left a comment

Choose a reason for hiding this comment

Uh oh!

donatieng left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

LMESTM left a comment

Choose a reason for hiding this comment

Uh oh!

Choose a reason for hiding this comment

Uh oh!

0xc0170 commented Feb 13, 2020

Uh oh!

mbed-ci commented Feb 13, 2020

Uh oh!

donatieng left a comment

Choose a reason for hiding this comment

Uh oh!

LMESTM commented Feb 18, 2020

Uh oh!

donatieng commented Feb 19, 2020

Uh oh!

LMESTM commented Feb 19, 2020

Uh oh!

mergify bot commented Feb 19, 2020

Uh oh!

0xc0170 commented Feb 19, 2020

Uh oh!

jeromecoutant commented Feb 20, 2020

Uh oh!

0xc0170 commented Feb 21, 2020

Uh oh!

mbed-ci commented Feb 21, 2020

Uh oh!

Uh oh!

donatieng left a comment •

edited

Loading