"device_name" not found - attempting to compile mbed-os-example-bootloader on NCS36510

[jacobjohnson-ON]

Description

• Type: Bug
• Related issue: #bootloader
• Priority: Blocker

---

Bug

Target
NCS36510

Toolchain:
GCC_ARM

Toolchain version:
5.06
mbed-cli version:
1.0.0

meed-os sha:
8b Merge pull request #8 from 0xc0170/fix_readme_blinky

DAPLink version:
0240

Expected behavior
Expected to compile and run the HAL and FlashIAP tests.

Actual behavior

I created "flash_api.c" with is the generated flash blob located here: https://github.com/mbedmicro/DAPLink/blob/master/source/target/onsemi/ncs36510/flash_blob.c

and followed the instructions on the slides here: https://github.com/ARMmbed/mbed-os-workshop-17q2/blob/master/Day%202%20-%20Entropy%2C%20Bootloader%2C%20Flash/04.%20mbed%20OS%20-%20Bootloader%2C%20Flash%20%2B%20Hands-on.pdf

after adding the phrase "bootloader_supported": true to the "targets.json" file, the following was displayed upon compile:

C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader>mbed compile -v
[mbed] Working path "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader
" (program)
[mbed] Exec "python -u C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootload
er\mbed-os\tools\make.py -t GCC_ARM -m NCS36510 --source . --build .\BUILD\NCS36510\GCC_ARM -v" in C
:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader
Traceback (most recent call last):
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\make.py", line 285, in
toolchain))
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\build_api.py", line 481, in build_project
build_profile=build_profile)
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\build_api.py", line 339, in prepare_toolchain
add_regions_to_profile(build_profile, config, cur_tc)
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\build_api.py", line 286, in add_regions_to_profile
regions = list(config.regions)
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\config.py", line 482, in regions
cmsis_part = Cache(False, False).index[self.target.device_name]
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\targets.py", line 256, in getattr
result = self.__getattr_helper(attrname)
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\targets.py", line 243, in __getattr_helper
% (attrname, self.name))
AttributeError: Attribute 'device_name' not found in target 'NCS36510'
[mbed] ERROR: "python" returned error code 1.
[mbed] ERROR: Command "python -u C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-exampl
e-bootloader\mbed-os\tools\make.py -t GCC_ARM -m NCS36510 --source . --build .\BUILD\NCS36510\GCC_AR
M -v" in "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader"

adding "device_name": "NCS36510" yields this error:

C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader>mbed compile -v
[mbed] Working path "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader
" (program)
[mbed] Exec "python -u C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootload
er\mbed-os\tools\make.py -t GCC_ARM -m NCS36510 --source . --build .\BUILD\NCS36510\GCC_ARM -v" in C
:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader
Traceback (most recent call last):
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\make.py", line 285, in
toolchain))
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\build_api.py", line 481, in build_project
build_profile=build_profile)
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\build_api.py", line 339, in prepare_toolchain
add_regions_to_profile(build_profile, config, cur_tc)
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\build_api.py", line 286, in add_regions_to_profile
regions = list(config.regions)
File "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader\mbed-os\tool
s\config.py", line 482, in regions
cmsis_part = Cache(False, False).index[self.target.device_name]
KeyError: 'NCS36510'
[mbed] ERROR: "python" returned error code 1.
[mbed] ERROR: Command "python -u C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-exampl
e-bootloader\mbed-os\tools\make.py -t GCC_ARM -m NCS36510 --source . --build .\BUILD\NCS36510\GCC_AR
M -v" in "C:\Users\fg8dfg\Documents\MBED_Partner_Workshop\Code\mbed-os-example-bootloader"

Steps to reproduce

[0xc0170]

@theotherjimmy I have seen this today on 2 devices. I cant reproduce this locally. The attribute error somehow gets in, it's not clear to me from the traceback why it needs this symbol for compiling?

[theotherjimmy]

Ah, I'll catch that exception and throw a better warning. device_name should be populated with something that is a CMSIS Part. This is required for bootloader builds to work properly.

[theotherjimmy]

PR to improve the error messages in a moment.

[theotherjimmy]

@jacobjohnson-ON the bootloader bulids require a information from CMSIS PACKS. This requirement should be better highlighted in the error messages now that #4061 has been merged. Could you comment on the status of this issue?

[ashok-rao]

@theotherjimmy .. I saw this today for SiLabs part. Initially, I got an error message (for something I was building with bootloader) that device_name is not present. I then added "device_name": ["EFR32MG12P332F1024GL125"] to targets.json. I got the device's name from KEIL's webpage: http://www.keil.com/dd2/siliconlaboratories/efr32mg12p332f1024gl125/ this is same device name that appears in CMSIS packs in MDK as well .. however, I still cannot build for this target.. some logs are below..

>mbed compile -t GCC_ARM -m TB_SENSE_12 --app-config configs\mesh_thread.json -vv
[mbed] Working path "C:\Ashok\SiLabs_ThunderSense2\example-sources-internal" (program)
[mbed] Exec "c:\python27\python.exe -u C:\Ashok\SiLabs_ThunderSense2\example-sources-internal\mbed-os\tools\make.py -t GCC_ARM -m TB_SENSE_12 --source . --build .\BUILD\TB_SENSE_12\GCC_ARM --app-config configs\mesh_thread.json -v" in C:\Ashok\SiLabs_ThunderSense2\example-sources-internal
Traceback (most recent call last):
  File "C:\Ashok\SiLabs_ThunderSense2\example-sources-internal\mbed-os\tools\make.py", line 296, in <module>
    stats_depth=options.stats_depth)
  File "C:\Ashok\SiLabs_ThunderSense2\example-sources-internal\mbed-os\tools\build_api.py", line 509, in build_project
    build_profile=build_profile)
  File "C:\Ashok\SiLabs_ThunderSense2\example-sources-internal\mbed-os\tools\build_api.py", line 355, in prepare_toolchain
    add_regions_to_profile(profile, config, cur_tc)
  File "C:\Ashok\SiLabs_ThunderSense2\example-sources-internal\mbed-os\tools\build_api.py", line 296, in add_regions_to_profile
    regions = list(config.regions)
  File "C:\Ashok\SiLabs_ThunderSense2\example-sources-internal\mbed-os\tools\config\__init__.py", line 504, in regions
    if self.target.device_name not in cache.index:
TypeError: unhashable type: 'list'
[mbed] ERROR: "c:\python27\python.exe" returned error code 1.
[mbed] ERROR: Command "c:\python27\python.exe -u C:\Ashok\SiLabs_ThunderSense2\example-sources-internal\mbed-os\tools\make.py -t GCC_ARM -m TB_SENSE_12 --source . --build .\BUILD\TB_SENSE_12\GCC_ARM --app-config configs\mesh_thread.json -v" in "C:\Ashok\SiLabs_ThunderSense2\example-sources-internal"
---**

[theotherjimmy]

@ashok-rao device_name is supposed to be a string, not a list. From your traceback, it looks like you did something like:

"TB_SENSE_12": {
    "device_name": ["EFR32MG12P332F1024GL125"]
}

which will not work, as a device can only have one name.

You should be able to drop the surrounding list, and get somewhere. For example:

"TB_SENSE_12": {
    "device_name": "EFR32MG12P332F1024GL125"
}

[ashok-rao]

Thanks @theotherjimmy , was able to get past without the [].

[theotherjimmy]

@ashok-rao Do you think the documentation should be improved to help users prevent this bug in the future?

[ashok-rao]

Would be nice to have them in the docs. I didn't find any docs particularly on the keys we/every target uses in targets.json .. I also may not have looked in the right places though..!

[theotherjimmy]

That document is the "Adding and Configuring Targets" section. It's somewhat hard to find. Where would you expect to find it?

[ashok-rao]

@theotherjimmy .. I'd expect to find this somewhere in the porting guide (adding / configuring a new target) under adding a new MCU here: https://os.mbed.com/docs/v5.6/reference/contributing-target.html