Problem with Makefile.tmpl

[tdjastrzebski]

I think there is a problem with Makefile.tmpl, line 138, probably introduced in commit 6918e6a as a result of #9596

Build under Visual Studio 2019 fails with error:

/usr/bin/sh: -c: line 0: unexpected EOF while looking for matching `"'
/usr/bin/sh: -c: line 1: syntax error: unexpected end of file
make[1]: *** [LCD_demo.elf] Error 1
C:/Test Projects/LCD_Make_VS/Makefile:530: recipe for target 'LCD_demo.elf' failed

and MAKEFILE line 529-532 read:

529> $(PROJECT).elf: $(OBJECTS) $(SYS_OBJECTS) $(PROJECT).link_script.ld 
530> 	+@echo "$(filter %.o, $^)" > .link_options.txt
531> 	+@echo "link: $(notdir $@)"
532> 	@$(LD) $(LD_FLAGS) -T $(filter-out %.o, $^) $(LIBRARY_PATHS) --output $@ @.link_options.txt $(LIBRARIES) $(LD_SYS_LIBS)

[0xc0170]

@tdjastrzebski Can you send Pr with the fix please

[tdjastrzebski]

@0xc0170 I would love to but my knowledge of sh and make is limited :/

[0xc0170]

cc @ARMmbed/mbed-os-tools

[mark-edgeworth]

Looks like a mismatched quote, but the code seems to be ok. What was the command line used to generate the makefile - I'll try and repeat it.

[tdjastrzebski]

@mark-edgeworth I do not know exactly how the makefile gets generated behind the scenes. I just exported the program as ZIP package using web interface. However, it seems file gets generated exactly the way it is supposed to, while VS 2019 compiler does not like it. Is that for a good reason? I am unable to tell. I can attach the complete project - if that may help.

[mark-edgeworth]

Ah, ok, you're exporting using the online IDE. That helps me reproduce this. Thanks for the info.

[tdjastrzebski]

I think the problem could be NMAKE does not recognize $^ macro while

a caret (^) within a quoted string is treated as a literal caret character

Source:
https://docs.microsoft.com/en-us/cpp/build/reference/filename-macros?view=vs-2019
https://docs.microsoft.com/en-us/cpp/build/reference/special-characters-in-a-makefile?view=vs-2019
https://www.gnu.org/software/make/manual/html_node/Automatic-Variables.html

[mark-edgeworth]

The $^ macro in gnu make represents all of the target's dependencies. Looks like nmake uses '$**' for the same thing. If the '$^' in the generated makefile is replaced with '$**', does this work for you?

[tdjastrzebski]

@mark-edgeworth That's intersting. Replacing the first (only) occurence of $^ with $** lets the build continue. Some other errors are outputed but, I believe, these are related to different issues.
The second instance of $^ (outside of quotes, 2 lines down) seems to be interpreted OK.
Here is the output:

link: DISCO-F769NI_LCD_demo.elf
c:/program files (x86)/microsoft visual studio/2019/preview/linux/gcc_arm/bin/../lib/gcc/arm-none-eabi/8.2.1/../../../../arm-none-eabi/bin/ld.exe: warning: cannot find entry symbol Reset_Handler; defaulting to 08000000
arm-none-eabi-objcopy -O binary DISCO-F769NI_LCD_demo.elf DISCO-F769NI_LCD_demo.bin
===== bin file ready to flash: BUILD/DISCO-F769NI_LCD_demo.bin =====
arm-none-eabi-objcopy -O ihex DISCO-F769NI_LCD_demo.elf DISCO-F769NI_LCD_demo.hex
arm-none-eabi-objcopy: DISCO-F769NI_LCD_demo.hex 64-bit address 0x4b4fa308000000 out of range for Intel Hex file
arm-none-eabi-objcopy:DISCO-F769NI_LCD_demo.hex: bad value
C:/Test Projects/DISCO-F769NI_LCD_Make_VS/Makefile:540: recipe for target 'DISCO-F769NI_LCD_demo.hex' failed
make[1]: *** [DISCO-F769NI_LCD_demo.hex] Error 1
Makefile:25: recipe for target 'all' failed
make: *** [all] Error 2

[mark-edgeworth]

Ok, that looks like progress, although I'd expect to have to replace all of the $^ references in the makefile for this to work correctly. If you can confirm that this resolves the problem that you originally reported I'll put a patch into the tools package to resolve this.