Update Event/EventQueue snippets to mirror updates to the API changes #125
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NOTE: will not pass the CI until the Mbed OS PR is merged ! |
|
Ahh looks like UserAllocatedEvent_ex1 also needs updating - will get than one added now. I'll check the other examples in the APIs_RTOS folder to make sure no others are also affected. Actually this is not the case as it turns out. UserAllocatedEvent has its own delay() and period() methods which have not been updated to use Chrono types yet. I will raise an issue to get these updated at a later date. |
|
Looks like we are going to revisit some of the inconsistencies in the event / event queue APIs and fix them all in one go, thus this PR is on hold for now. |
0xc0170
approved these changes
Feb 5, 2021
evedon
approved these changes
Feb 5, 2021
Also show how to use non_periodic and cancel. Add timestamp to event printf and add expected results
Mbed OS is being updated to bring the event queue dispatch function in line with other event functions in moving to using chrono times. This commit updates the associated snippet examples accordingly. It also fixes the use of the new split dispatch functions: dispatch_once(), dispatch_for(duration ms), dispatch_forever()
|
@0xc0170 looks like we can merge this ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ARMmbed/mbed-os#13975 updates the EventQueue dispatch API to
a) dispatch_for(duration ms)
b) dispatch_once()
c) dispatch_forever()
This PR updates the example snippets to mirror this functionality.