Skip to content

State the examples work on all Mbed OS devices #226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jan 7, 2019

Conversation

RonEld
Copy link
Contributor

@RonEld RonEld commented Jan 3, 2019

Remove statement that the examples work only on K64F.
Resolves #223

Remove statement that the examples work only on K64F.
Copy link
Contributor

@simonbutcher simonbutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor language issues.

README.md Outdated
@@ -5,13 +5,9 @@ This repository contains a collection of Mbed TLS example applications based on
# Getting started

## Required hardware
* An [FRDM-K64F](http://os.mbed.com/platforms/FRDM-K64F/) development board.
* Any Mbed OS capable development board listed [here](https://os.mbed.com/platforms/), which has an entropy source integrated with Mbed TLS. The single example that does not need an entropy source is `hashing`. The `tls-client` example should also have a network interface supported on your board.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some minor grammar issues:

'Any Mbed OS capable development board such as those listed [here]...'

'which have an entropy source integrated into Mbed TLS'

Copy link

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, except for the minor issues already pointed out by Simon. Please ping me when you fixed them.

fix grammar errors in the sentence.
@RonEld
Copy link
Contributor Author

RonEld commented Jan 6, 2019

@sbutcher-arm @mpg Thank you for your review.
I have addressed your issues.

Copy link

@mpg mpg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Re-approving for last commit.

@simonbutcher simonbutcher merged commit c21526b into ARMmbed:master Jan 7, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants