-
Notifications
You must be signed in to change notification settings - Fork 51
State the examples work on all Mbed OS devices #226
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Remove statement that the examples work only on K64F.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor language issues.
README.md
Outdated
@@ -5,13 +5,9 @@ This repository contains a collection of Mbed TLS example applications based on | |||
# Getting started | |||
|
|||
## Required hardware | |||
* An [FRDM-K64F](http://os.mbed.com/platforms/FRDM-K64F/) development board. | |||
* Any Mbed OS capable development board listed [here](https://os.mbed.com/platforms/), which has an entropy source integrated with Mbed TLS. The single example that does not need an entropy source is `hashing`. The `tls-client` example should also have a network interface supported on your board. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Some minor grammar issues:
'Any Mbed OS capable development board such as those listed [here]...'
'which have an entropy source integrated into Mbed TLS'
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good to me, except for the minor issues already pointed out by Simon. Please ping me when you fixed them.
fix grammar errors in the sentence.
@sbutcher-arm @mpg Thank you for your review. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Re-approving for last commit.
Remove statement that the examples work only on K64F.
Resolves #223