Skip to content

Fix unsuitable use of exit_code in authcrypt #221

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Dec 14, 2018

Conversation

andresag01
Copy link

The exit_code variable in authcrypt is meant to hold the main() return value to the system. However, it was also being shared with the return value for internal functions. This PR splits the two uses and introduces a variable ret for holding internal return values.

Addresses #205

Copy link
Contributor

@simonbutcher simonbutcher left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@simonbutcher
Copy link
Contributor

retest

@simonbutcher simonbutcher merged commit a785736 into ARMmbed:master Dec 14, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants