Undefine MBEDTLS_MPI_MAX_SIZE #220
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
k-stachowiak
approved these changes
Dec 4, 2018
|
Just a minor note: merging ARMmbed/mbed-os#8936 will not actually cause trouble until the next Mbed TLS update in the Mbed OS. |
Correct, I explained it wrong |
Patater
reviewed
Dec 4, 2018
| @@ -33,6 +33,9 @@ | |||
| * Set this value higher to enable handling larger keys, but be aware that this | |||
| * will increase the stack usage. | |||
| */ | |||
| #if defined(MBEDTLS_MPI_MAX_SIZE) | |||
| #undef MBEDTLS_MPI_MAX_SIZE | |||
There was a problem hiding this comment.
You should be able to unconditionally undef this. There are no warnings if it isn't defined, right?
Undefine `MBEDTLS_MPI_MAX_SIZE` in case it is already defined in the configuration file.
RonEld
force-pushed
the
undefine_mpi_max_size
branch
from
8b17022 to
0b991cb
Compare
|
@Patater I changed according to your comment, in the same commit, as the change is minimal |
k-stachowiak
approved these changes
Dec 4, 2018
AndrzejKurek
approved these changes
Dec 6, 2018
|
I can understand this PR is required within the constraints of the current configuration system, but I think |
|
retest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Undefine
MBEDTLS_MPI_MAX_SIZEin case it is already definedin the configuration file.
This should avoid compilation warnings and unintended behaviour, once ARMmbed/mbed-os#8936 will be merged