Update root certificate in the tls-client example #217
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
retest |
|
The tls-client in the current state cannot retrieve data from the server. It's being investigated. |
|
retest |
HTTP line endings must be terminated with CRLF, and the final line must be a blank line. The code previously ended lines with `\n`. This changes changes the line endings to `\r\n` and ensures the extra blank line at the end.
|
retest |
Patater
approved these changes
Nov 20, 2018
|
CI passes with only known issues, therefore this PR can be merged. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The root certificate in the tls-client example has been invalidated, and needs to be updated. This PR introduces the new certificate into the example application.
In addition, this PR changes the line endings for the HTTP GET. HTTP line endings must be terminated with CRLF, and the final line must be a blank line. The code previously ended lines with
\n. This changes changes the line endings to\r\nand ensures the extra blank line at the end.Fixes #218.